Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
?in canonical redirect URLs (router.d)max_upload_size, notmax_request_size(post.d)response.d)logConnectioncalled twice for keepalive connections - fixed withstarttimeguard (client.d)completed,modified,process.terminatedin CGI process thread (process.d)?bug in query string for canonical redirects (router.d)cgi.d,response.d)Hostheader (request.d)Security / Robustness
parseXform(post.d)ready()return type corrected fromlongtoboolacrossPayloadinterfacepayload &&truthiness checks replaced withpayload !is null(client.d,interfaces.d,response.d,post.d)Shutdown & Cleanup
SetConsoleCtrlHandler(signals.d)registerExitHandler()(signals.d)runRequestexits immediately onshutdownSignal- no stale unittest runs after Ctrl+C (router.d).infiles now cleaned up viascope(exit)chain:client → response.kill() → process scope(exit)(process.d,response.d,client.d)safeClose/safeRemovenothrow helpers for guaranteed cleanup (process.d)Streaming Multipart Uploads
MultipartParserstate machine inmultipart.d- streams file data directly to disk as chunks arriveinbuffernever accumulates upload body -receiveChunk()drains buffered bytes then reads socket directlytrimToHeader()called once on first chunk, header preserved ininbufferthroughoutDead Code & Refactoring
request.maxtimefield,get()method onRequest,blockingstored fieldhavepostmoved fromResponsetoRequest.postParsedDomain.entries/bufferedconverted from stored fields to computed propertiesPostItem/PostTypemoved frompost.dtorequest.d(semantic home)notFound,forbidden,serveCGIetc.) moved torouter.dFilePayload/FileStreammoved fromfiles.dtopayload.disCGI,safePath,resolveetc.) moved tofilesystem.dendofheader,bodystart,fullheader,sISelect) consolidatedwebconfig ↔ sslviafilesystem ↔ files)api/danode.dsetPOST()fixed for values containing=charactersTest Coverage
multipart.d,client.d,request.d,files.d,post.d