Skip to content

[Snyk] Security upgrade @angular/cli from 20.3.9 to 21.0.0#129

Open
Dargon789 wants to merge 1 commit intomasterfrom
snyk-fix-7fe5a8149d4ee943325545aa079dfb9c
Open

[Snyk] Security upgrade @angular/cli from 20.3.9 to 21.0.0#129
Dargon789 wants to merge 1 commit intomasterfrom
snyk-fix-7fe5a8149d4ee943325545aa079dfb9c

Conversation

@Dargon789
Copy link
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • frontend/package.json
  • frontend/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  713  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

…nerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-TAR-15038581
@codesandbox
Copy link

codesandbox bot commented Jan 20, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving a critical vulnerability. It achieves this by updating a key development dependency, @angular/cli, to a newer, more secure version, ensuring the project benefits from the latest security patches and improvements.

Highlights

  • Security Vulnerability Fix: This pull request addresses and fixes one security vulnerability, "Improper Handling of Unicode Encoding" (SNYK-JS-TAR-15038581), which has a severity score of 713.
  • Dependency Upgrade: The @angular/cli dependency has been upgraded from version ^20.3.3 to ^21.0.0 to resolve the identified vulnerability.
  • Automated PR: This pull request was automatically generated by Snyk to apply the necessary security upgrade.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix a security vulnerability by upgrading @angular/cli. However, this upgrade introduces a major version bump (v20 to v21) which creates a significant version mismatch with your other Angular framework packages (mostly v17). This is very likely to break your build process. I've left a critical comment with a recommendation for a safer alternative to resolve the vulnerability without introducing breaking changes.

"@angular-devkit/build-angular": "^17.3.16",
"@angular/animations": "^17.3.1",
"@angular/cli": "^20.3.3",
"@angular/cli": "^21.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR upgrades @angular/cli to a new major version (v21), while most other Angular packages in this project are on v17 (e.g., @angular/core: ^17.3.1) and some are even on v19.

The Angular CLI's version is tightly coupled with the Angular framework's version. A major version mismatch like this is highly likely to break your build process and cause other hard-to-debug compatibility issues.

Since the goal is to fix a vulnerability in the tar package (a transitive dependency of @angular/cli), a safer approach is to force an update of tar directly. You can do this by reverting this change and adding an overrides section to your package.json.

Example of what to add to package.json:

"overrides": {
  "tar": ">=6.2.1"
}

This will resolve the security vulnerability without the risk of breaking changes from a major CLI upgrade. After adding the override and reverting the change to @angular/cli, run npm install to apply the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments