Skip to content

Refactor CircleCI config for testing workflow#478

Merged
Dargon789 merged 1 commit into
wagmi-projectfrom
Dargon789-patch-1
Apr 25, 2026
Merged

Refactor CircleCI config for testing workflow#478
Dargon789 merged 1 commit into
wagmi-projectfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Copy Markdown
Owner

@Dargon789 Dargon789 commented Apr 25, 2026

Summary by Sourcery

Refactor CircleCI configuration to use a simplified Foundry-based test job and workflow.

CI:

  • Replace the custom executor and image with a Foundry Docker image for the test job.
  • Consolidate CI into a single test job that checks out code, updates git submodules, builds with forge, and runs tests with verbose output.
  • Rename the workflow to main to run the new test job.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 25, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

This comment was marked as resolved.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 25, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the CircleCI pipeline to a simpler test-focused workflow using a Foundry Docker image, adding explicit build/test steps and renaming the workflow and job to "test"/"main" while removing the custom executor.

File-Level Changes

Change Details Files
Replace custom executor-based job with a Foundry-based test job.
  • Remove the custom Docker executor configuration with authenticated Docker Hub image.
  • Define a new test job that runs on the ghcr.io/foundry-rs/foundry:latest Docker image.
  • Keep the checkout step and add structured run steps for submodule initialization, build, and tests.
.circleci/config.yml
Simplify and rename the workflow to use the new test job.
  • Remove the previous my-custom-workflow workflow that invoked the old job.
  • Create a new main workflow that runs the test job.
.circleci/config.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Apr 25, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Consider pinning the Foundry Docker image to a specific version/tag instead of latest to ensure reproducible builds and avoid unexpected CI breakages when the image is updated.
  • You might want to add CircleCI caching (e.g., for build artifacts or dependencies used by forge build/forge test) to reduce CI time on subsequent runs.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider pinning the Foundry Docker image to a specific version/tag instead of `latest` to ensure reproducible builds and avoid unexpected CI breakages when the image is updated.
- You might want to add CircleCI caching (e.g., for build artifacts or dependencies used by `forge build`/`forge test`) to reduce CI time on subsequent runs.

## Individual Comments

### Comment 1
<location path=".circleci/config.yml" line_range="9-14" />
<code_context>
-      - run: |
-          # echo Hello, World!
-
+      - run:
+          name: Install submodules
+          command: git submodule update --init --recursive
+      - run:
+          name: Build
+          command: forge build
+      - run:
+          name: Test
</code_context>
<issue_to_address>
**suggestion (performance):** Consider adding CircleCI caching around the build to speed up repeated runs.

Since `forge build` is relatively expensive, consider wrapping it with CircleCI `save_cache`/`restore_cache` for the build artifacts (e.g., `out` and `cache`), keyed by the `forge` version and relevant lockfiles, to speed up subsequent CI runs.
</issue_to_address>

Fix all in Cursor


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread .circleci/config.yml
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CircleCI configuration to implement a testing pipeline using the Foundry toolchain. The changes replace a placeholder job with a 'test' job that handles submodule initialization, project building, and test execution. Review feedback recommends pinning the Docker image version to ensure build reproducibility and removing the redundant 'forge build' step, as 'forge test' automatically performs a build before running tests.

Comment thread .circleci/config.yml
Comment thread .circleci/config.yml
@Dargon789 Dargon789 merged commit db8a20f into wagmi-project Apr 25, 2026
12 of 18 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch April 25, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant