Codesandbox dev#528
Merged
Merged
Conversation
Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express). Updates `express` from 4.18.2 to 4.19.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: direct:development dependency-group: npm_and_yarn-security-group ... Signed-off-by: dependabot[bot] <support@github.com>
[skip ci]
…ity-group-e0cd778f82
…yarn-security-group-e0cd778f82 Bump the npm_and_yarn group across 1 directory with 1 update
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
|
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
Reviewer's GuideAdds a new Codesandbox-friendly wagmi Vite demo app plus security/CI workflows and repository metadata, and bumps the indexer service changelog with a 2.0.0 entry. Sequence diagram for wallet connect and disconnect in the wagmi appsequenceDiagram
actor BrowserUser
participant AppComponent
participant WagmiProvider
participant Connector
participant BlockchainNetwork
BrowserUser->>AppComponent: Load_application
AppComponent->>WagmiProvider: Initialize_useAccount_useConnect_useDisconnect
WagmiProvider-->>AppComponent: Provide_account_connectors_status
BrowserUser->>AppComponent: Click_connect_button_with_selected_connector
AppComponent->>WagmiProvider: connect(connector)
WagmiProvider->>Connector: Start_connection
Connector->>BrowserUser: Prompt_for_wallet_approval
BrowserUser-->>Connector: Approve_connection
Connector->>BlockchainNetwork: Establish_session
BlockchainNetwork-->>Connector: Session_established
Connector-->>WagmiProvider: Connection_success
WagmiProvider-->>AppComponent: Update_account_status_connected
AppComponent-->>BrowserUser: Render_account_info_and_Disconnect_button
BrowserUser->>AppComponent: Click_Disconnect_button
AppComponent->>WagmiProvider: disconnect()
WagmiProvider->>Connector: Terminate_session
Connector->>BlockchainNetwork: Close_session
BlockchainNetwork-->>Connector: Session_closed
Connector-->>WagmiProvider: Disconnected
WagmiProvider-->>AppComponent: Update_account_status_disconnected
AppComponent-->>BrowserUser: Render_disconnected_state
Class diagram for the wagmi Vite demo app structureclassDiagram
class AppComponent {
+useAccount account
+useConnectResult connectResult
+useDisconnectResult disconnectResult
+render(): JSX
}
class MainEntry {
+Buffer globalBuffer
+QueryClient queryClient
+bootstrap(rootElementId)
}
class WagmiConfigModule {
+Config config
+createConfig(chains, connectors, transports)
}
class QueryClient {
+QueryClient()
}
class WagmiProvider {
+config Config
}
class QueryClientProvider {
+client QueryClient
}
class Connector {
+string uid
+string name
}
class AccountState {
+string status
+string[] addresses
+number chainId
}
class ConnectResult {
+Connector[] connectors
+function connect(connector)
+string status
+Error error
}
class DisconnectResult {
+function disconnect()
}
AppComponent --> AccountState : uses
AppComponent --> ConnectResult : uses
AppComponent --> DisconnectResult : uses
ConnectResult --> Connector : exposes
MainEntry --> WagmiProvider : wraps
MainEntry --> QueryClientProvider : wraps
MainEntry --> AppComponent : renders
MainEntry --> WagmiConfigModule : imports
MainEntry --> QueryClient : instantiates
WagmiProvider --> WagmiConfigModule : uses_config
QueryClientProvider --> QueryClient : uses
WagmiConfigModule --> Connector : defines
WagmiConfigModule --> WagmiProvider : config_type_declaration
AccountState <.. WagmiProvider : provided_by
ConnectResult <.. WagmiProvider : provided_by
DisconnectResult <.. WagmiProvider : provided_by
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 5 issues, and left some high level feedback:
- It looks like
v8-compile-cache-0/...artifacts and other tooling/runtime outputs (e.g..codesandbox/tasks.json) have been committed; consider removing these and updating.gitignoreto prevent them from being tracked. - The Azure pipeline is configured to install Node 10.x, which is incompatible with modern tooling like Vite 5 and React 18; align the pipeline Node version with the version required by the new
wagmi-project. - If
wagmi-projectis intended as a sample or sandbox app, consider relocating it under anexamples/sandboxdirectory and/or wiring it into the existing workspace tooling so it’s clearly separated from production packages.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- It looks like `v8-compile-cache-0/...` artifacts and other tooling/runtime outputs (e.g. `.codesandbox/tasks.json`) have been committed; consider removing these and updating `.gitignore` to prevent them from being tracked.
- The Azure pipeline is configured to install Node 10.x, which is incompatible with modern tooling like Vite 5 and React 18; align the pipeline Node version with the version required by the new `wagmi-project`.
- If `wagmi-project` is intended as a sample or sandbox app, consider relocating it under an `examples`/`sandbox` directory and/or wiring it into the existing workspace tooling so it’s clearly separated from production packages.
## Individual Comments
### Comment 1
<location path="azure-pipelines.yml" line_range="15" />
<code_context>
+steps:
+- task: NodeTool@0
+ inputs:
+ versionSpec: '10.x'
+ displayName: 'Install Node.js'
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Node 10 in the build pipeline is likely incompatible with the toolchain used in `wagmi-project`.
This toolchain (Vite 5, React 18.3, TS 5.x) requires a modern Node version (typically ≥18); using Node 10 is likely to break the build or cause runtime issues. Please update `versionSpec` to something like `'18.x'` or `'20.x'`. If this pipeline is meant to build `wagmi-project`, also ensure the working directory is set there (or `cd wagmi-project`) before `npm install`/`npm run build` so the correct package is built.
</issue_to_address>
### Comment 2
<location path="wagmi-project/package.json" line_range="14-17" />
<code_context>
+ "@tanstack/react-query": "5.45.1",
+ "react": "^18.3.1",
+ "react-dom": "^18.3.1",
+ "viem": "latest",
+ "wagmi": "latest"
+ },
+ "devDependencies": {
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Using `latest` for `viem` and `wagmi` can introduce unexpected breaking changes over time.
Please pin `viem` and `wagmi` to specific versions (or a caret range like `^x.y.z`) so builds remain reproducible and don’t break when new major or breaking releases ship, especially given how fast these web3 libraries change.
```suggestion
"react": "^18.3.1",
"react-dom": "^18.3.1",
"viem": "^2.7.20",
"wagmi": "^2.10.5"
```
</issue_to_address>
### Comment 3
<location path="wagmi-project/package.json" line_range="25" />
<code_context>
+ "@types/react-dom": "^18.3.0",
+ "@vitejs/plugin-react": "^4.2.1",
+ "@wagmi/cli": "latest",
+ "buffer": "^6.0.3",
+ "typescript": "^5.4.5",
+ "vite": "^5.2.11"
</code_context>
<issue_to_address>
**issue (bug_risk):** The `buffer` package is used at runtime but is listed under `devDependencies`.
Since `src/main.tsx` assigns `buffer` to `globalThis.Buffer` in the browser bundle, it’s required at runtime. Keeping it in `devDependencies` risks it not being installed in production, so it should be moved to `dependencies` to ensure it’s always available.
</issue_to_address>
### Comment 4
<location path="wagmi-project/src/wagmi.ts" line_range="10" />
<code_context>
+ connectors: [
+ injected(),
+ coinbaseWallet(),
+ walletConnect({ projectId: import.meta.env.VITE_WC_PROJECT_ID }),
+ ],
+ transports: {
</code_context>
<issue_to_address>
**issue (bug_risk):** Using `walletConnect` without guarding against a missing `VITE_WC_PROJECT_ID` can cause runtime failures.
If this env var is undefined or empty, `walletConnect` may throw on startup or produce a broken connector. Please validate `import.meta.env.VITE_WC_PROJECT_ID` before constructing this connector, or only add it to `connectors` when the env var is set, so misconfigured environments fail gracefully.
</issue_to_address>
### Comment 5
<location path="SECURITY.md" line_range="5-14" />
<code_context>
+
+## Supported Versions
+
+Use this section to tell people about which versions of your project are
+currently being supported with security updates.
+
+| Version | Supported |
+| ------- | ------------------ |
+| 5.1.x | :white_check_mark: |
+| 5.0.x | :x: |
+| 4.0.x | :white_check_mark: |
+| < 4.0 | :x: |
+
+## Reporting a Vulnerability
+
+Use this section to tell people how to report a vulnerability.
+
+Tell them where to go, how often they can expect to get an update on a
+reported vulnerability, what to expect if the vulnerability is accepted or
+declined, etc.
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Replace placeholder security policy text with project-specific details.
This section still uses the default template text (e.g., “Use this section to tell people…”). Please replace it with your actual supported versions matrix and concrete instructions for reporting vulnerabilities, including where to report and typical response timelines.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new project structure using Vite and Wagmi, including CI/CD pipelines, issue templates, and environment configurations. Feedback focuses on modernizing the azure-pipelines.yml by updating the Node.js version to LTS and switching to pnpm for consistency. Critical issues were identified regarding the accidental commitment of cache files and the use of "latest" for package dependencies, which should be pinned. Additionally, the reviewer suggested validating environment variables in wagmi.ts, removing placeholder text from documentation and templates, and stripping non-standard comments from JSON files.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
* Bump next from 15.5.14 to 15.5.15 (0xsequence#989) Bumps [next](https://github.com/vercel/next.js) from 15.5.14 to 15.5.15. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.14...v15.5.15) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.15 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update to latest pnpm * 3.0.8 * Fix fee options stub signature (0xsequence#999) * 3.0.9 * Enforce minimum age limitation for packages --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: tolgahan-arikan <tolgahan.arikan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add a new wagmi-based demo app and integrate additional security and CI workflows.
New Features:
Enhancements:
Build:
CI:
Deployment:
Documentation: