Skip to content

Tweaks to Melee roll display and calculation#1206

Open
FalloutFalcon wants to merge 5 commits into
DarkPack13:masterfrom
FalloutFalcon:weapon-readouts
Open

Tweaks to Melee roll display and calculation#1206
FalloutFalcon wants to merge 5 commits into
DarkPack13:masterfrom
FalloutFalcon:weapon-readouts

Conversation

@FalloutFalcon

@FalloutFalcon FalloutFalcon commented Jul 7, 2026

Copy link
Copy Markdown
Member

About The Pull Request

Some tweaks after a discussion that fixes a few issues weapons have rn

I also made a TG pr that adds a bunch more information that was not specfic to us, specificly displaying damage type is neat as aggravated damage is alot diffrent to brute/bashing.
(the takes about melee hits thing prob needs to be removed as its hella inaccurate now but throwing still works how it used to so idk what to do with that part of it.)
image

Why It's Good For The Game

While I wouldn't recommend it, weapons with decimal amount of bonus dice should have SOME effect probably.
Conveying information is always better imo and helps clear up a little ambiguity with the current system.
And most items below 1 TTRPG_DAMAGE are not a weapon so you shouldn't one shot yourself because you clicked on yourself with a pen but oops your a like, 5 strength 5 melee terrorist.

Changelog

🆑
qol: Attack information as it relates to rolls is now displayed in a weapons combat information
qol: Attacking with a weapon BELOW a single bonus dice no longer makes a roll that includes your entire dice pool
balance: Weapons with a dice pool that is not rounded turns the remainder into a chance for a bonus dice.
/:cl:

@chazzyjazzy chazzyjazzy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the "it has a dice bonus of 6" thing, (which is really just a prob() for +1 bonus dice) which may be kind of confusing for people, there is really no problem with this, just some typos

Comment thread code/__DEFINES/~darkpack/combat.dm Outdated
Comment thread code/_onclick/item_attack.dm Outdated
Comment thread code/_onclick/item_attack.dm Outdated
Comment thread code/datums/elements/weapon_description.dm Outdated
FalloutFalcon and others added 4 commits July 10, 2026 12:59
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants