Tweaks to Melee roll display and calculation#1206
Open
FalloutFalcon wants to merge 5 commits into
Open
Conversation
chazzyjazzy
approved these changes
Jul 8, 2026
chazzyjazzy
left a comment
Contributor
There was a problem hiding this comment.
besides the "it has a dice bonus of 6" thing, (which is really just a prob() for +1 bonus dice) which may be kind of confusing for people, there is really no problem with this, just some typos
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
Co-authored-by: chazzyjazzy <33268885+chazzyjazzy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Some tweaks after a discussion that fixes a few issues weapons have rn
I also made a TG pr that adds a bunch more information that was not specfic to us, specificly displaying damage type is neat as aggravated damage is alot diffrent to brute/bashing.

(the takes about melee hits thing prob needs to be removed as its hella inaccurate now but throwing still works how it used to so idk what to do with that part of it.)
Why It's Good For The Game
While I wouldn't recommend it, weapons with decimal amount of bonus dice should have SOME effect probably.
Conveying information is always better imo and helps clear up a little ambiguity with the current system.
And most items below 1 TTRPG_DAMAGE are not a weapon so you shouldn't one shot yourself because you clicked on yourself with a pen but oops your a like, 5 strength 5 melee terrorist.
Changelog
🆑
qol: Attack information as it relates to rolls is now displayed in a weapons combat information
qol: Attacking with a weapon BELOW a single bonus dice no longer makes a roll that includes your entire dice pool
balance: Weapons with a dice pool that is not rounded turns the remainder into a chance for a bonus dice.
/:cl: