Notifactions and some text message code#1209
Open
FalloutFalcon wants to merge 5 commits into
Open
Conversation
chazzyjazzy
approved these changes
Jul 9, 2026
chazzyjazzy
left a comment
chazzyjazzy
left a comment
Contributor
There was a problem hiding this comment.
can't see anything bad
| ANNOUNCEMENT_TYPE_PRIORITY, | ||
| color_override = "red", | ||
| ) | ||
| endpost_announce("A rolling blackouts are affecting your area due to inclement weather. City workers are delayed due to a wife affected area.") |
Contributor
There was a problem hiding this comment.
HAHAHAHAHAHAHAHAHA
Suggested change
| endpost_announce("A rolling blackouts are affecting your area due to inclement weather. City workers are delayed due to a wife affected area.") | |
| endpost_announce("Rolling blackouts are impacting your area due to inclement weather. City workers are delayed due to widespread outages across the city.") |
| animate(pixel_w = 2, time = 0.1 SECONDS, flags = ANIMATION_RELATIVE|ANIMATION_CONTINUE) | ||
| animate(pixel_w = -1, time = 0.1 SECONDS, flags = ANIMATION_RELATIVE) | ||
| if(ringer) | ||
| playsound(src, 'modular_darkpack/modules/phones/sounds/text_receive.ogg', 50, TRUE, 0, 2) // This could prob use a better notification |
Contributor
There was a problem hiding this comment.
well for the events we do have news_notification.ogg from earlier which appears to go unused now if you want to add some like random chance or whatev
| balloon_alert_to_viewers(message = "New Message!", vision_distance = SAMETILE_MESSAGE_RANGE) | ||
| return TRUE | ||
| /obj/item/smartphone/proc/after_text_received(contact_name, message_text) | ||
| // This should support having your notifiactions set to hidden to not show detials without opening the app. |
Contributor
There was a problem hiding this comment.
if(ringer) appeared to do something like that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Endpost and Message+ now use a generic helper for notification.
Also had to fix
get_number_contact_namebecause it was acctually just raw not working for the existing message code. it was pulling the number from phone call behavoir because someone hardcoded it.We really out to have a proper notifcation in the phone ui itself but all the phone code is extreamly hardcoded and it needs as hella rework tbh.
Apps not being isolated datums makes me cry. Modular computers are right there...
Why It's Good For The Game
Notifications are nice.
Changelog
🆑
add: Endpost and Message+ now use a generic helper for displaying a notification as a balloon alert.
fix: Text messages properly use the phone numbers for the texters rather then phones
/:cl: