Fix the url docs link and handling referenced json files#99
Open
aiolos wants to merge 4 commits intoDarkaOnLine:masterfrom
Open
Fix the url docs link and handling referenced json files#99aiolos wants to merge 4 commits intoDarkaOnLine:masterfrom
aiolos wants to merge 4 commits intoDarkaOnLine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an application I'm using references to json files in my swagger documentation (these files are also used for validation of requests and responses, as well as tests, that why I want to use these references and don't put them inline).
In the laravel-package this works correctly, but the lumen-package didn't use the file name in the docs correctly, and referenced files were also not served through the
SwaggerLumeController.I applied changes that give the expected result. I.e. the default docs url is now
.../docs/api-docs.json(in comparison to../docs/it was before, and json files referenced in api-docs.json are served correctly.Let me know if anything is unclear.