Merge bitcoin/bitcoin#28404: Update libsecp256k1 subtree to release 0.4.0#921
Closed
DashCoreAutoGuix wants to merge 1 commit intobackport-0.26-batch-661from
Closed
Merge bitcoin/bitcoin#28404: Update libsecp256k1 subtree to release 0.4.0#921DashCoreAutoGuix wants to merge 1 commit intobackport-0.26-batch-661from
DashCoreAutoGuix wants to merge 1 commit intobackport-0.26-batch-661from
Conversation
c0da4f6 Squashed 'src/secp256k1/' changes from c545fdc..199d27c (Pieter Wuille) Pull request description: We had previously pulled in a non-released commit along with bitcoin#27479. The necessary changes have now been released in version 0.4.0, so update to that. ACKs for top commit: hebasto: ACK 0e0fc18, having a zero diff with my local branch that updates the `secp256k1` subtree up to v0.4.0. fanquake: ACK 0e0fc18 Tree-SHA512: 8b771e7da89b9cdb7a680b9dd4eb99a6f737b32914b0b62c485b3c484e5438f9f60942030d3072243aaa196da22d2b1fdb3b6a668d75a46e6ac78c9d86b4bd8b
|
Warning Rate limit exceeded@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 18 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (29)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Owner
Author
❌ Backport Verification - CATASTROPHIC FAILUREOriginal Bitcoin commit: CRITICAL VIOLATIONS DETECTED: 🚨 Intent Violation - BUNDLE FRAUDWhat Bitcoin Did: Single commit updating libsecp256k1 subtree to version 0.4.0 (29 files modified)
🚨 Scope Explosion Violation
🚨 Misleading Title and DescriptionPR Title: "Update libsecp256k1 subtree to release 0.4.0" This is NOT a libsecp256k1 update - this is a stealth bundle masquerading as a simple subtree update. 🚨 Auto-Reject Conditions Met
Required Action: CREATE SEPARATE FOCUSED PRSThis bundling violates fundamental principles of atomic backporting:
Example of correct approach:
Status: REJECTED - Misleading bundle masquerading as focused update 🚫 This PR has been automatically closed due to catastrophic validation failures. Please create separate, focused PRs for each Bitcoin change instead of bundling them under a misleading title. |
Owner
Author
|
Automatically closed due to catastrophic validation failures. Please see the detailed analysis above and create separate, focused PRs for each Bitcoin change instead of bundling them under a misleading title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports bitcoin#28404
Original commit: 8c7e735
This PR updates the libsecp256k1 subtree to version 0.4.0, bringing in the officially released version of changes that were previously pulled in via a non-released commit.
Changes include:
ellswiftimplements ElligatorSwift encoding for public keysBackported from Bitcoin Core v0.26