refactor: make codeResponse fields optional (#907)#908
Merged
frano-m merged 1 commit intoMay 5, 2026
Conversation
google's oauth code-flow callback returns either a success payload (code, scope, state) or an error payload (error, error_description, error_uri, state) — required strings on every field misrepresent the contract. trim the test fixture down to the only field we actually populate. Closes #907 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the newly introduced Google OAuth authorization-code callback typing so it matches Google’s real-world “success vs error” payload shapes, and simplifies the related test fixture accordingly.
Changes:
- Make all
CodeResponsefields optional to reflect that success/error responses have disjoint fields. - Reduce the
CODE_RESPONSEtest fixture to only the populatedcodefield.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/google/types.ts |
Loosens CodeResponse field requirements so omitted fields are correctly representable. |
tests/googleService.test.ts |
Simplifies the code-flow callback fixture to match actual usage and the updated type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CodeResponsefrom requiredstringto optional, so the type reflects Google's actual code-flow callback contract (success vs error payloads have disjoint fields)CODE_RESPONSEtest fixture down to the only field we actually populateStacked on top of #905 (which introduces
CodeResponse); will rebase ontomainonce that lands.Closes #907.
Test plan
npm run check-formatcleannpm run lintcleannpm run test-compilecleannpm test— 47 suites, 392 tests pass