Fix: Staging area validator incorrectly fails on supplementary LungMAP file#27
Conversation
fb8d33d to
96db216
Compare
|
While this code technically works, I would not recommend it. It appears to me that it will search for "matrix" within any of the values of the content_description dictionary. For ontology fields, there are several valid terms that contain the word matrix, but that are not data:2082. The "text" field is the only field required and this could be anything, such as "My favorite Ice Cream matrix". Finally, the specification dictates a requirement of the content description "is set to" So, even a value of the following should not trigger the strata check: I would recommend re-working the code to check for the specific structure that is outlined in the DCP/2 System Design documentation. |
|
From email conversations, Hannes mentioned that "This is the same condition that Azul applies, for historical reasons. We believe it's more important for the validator to be consistent with Azul, than to prevent the scenario you are describing." He confirmed with Joshua that this is not a blocker for the current datasets being submitted, and that we can re-address his comment if and when it becomes an issue. |
ncalvanese1
left a comment
There was a problem hiding this comment.
See conversation in the comments. Solution should be sufficient for now, and match Azul conditions.
DataBiosphere/azul#7478