DDO-4131 read from google artifact registry#93
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: c3b5f5e | Previous: 71f0a13 | Ratio |
|---|---|---|---|
bio.terra.pfb.LibraryBenchmarks.showNodesMedium |
1916.8210357577227 ops/s |
1873.4219649561683 ops/s |
1.02 |
bio.terra.pfb.LibraryBenchmarks.showNodesSmall |
25415.58649864174 ops/s |
24918.878999787165 ops/s |
1.02 |
bio.terra.pfb.PfbReaderBenchmarks.convertEnum |
5245563.310194643 ops/s |
5305296.193032701 ops/s |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
|
|
kevinmarete
approved these changes
Jun 2, 2025
calypsomatic
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DDO-4131
Summary of changes
Updated the artifact source for this service to read artifacts from Google Artifact Registry instead of JFrog.
What
Modified the config to pull artifacts from GAR. No publishing changes were made.
Why
This is part of Phase 2 of the artifact migration effort to deprecated JFrog and consolidate artifacts in GAR.
Testing these changes
Relied on passing CI checks and tests. Artifact reading-related issues are expected to surface as pipeline failures. For example these jobs here and here failed due to access issues (which have since been resolved).