fix: support Python 3.10#87
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR lowers the minimum supported Python version to 3.10 by updating ChangesPython 3.10 Minimum Version Support
Unrelated Refactor
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Lowers the Python package minimum from 3.12 to 3.10 and adds the new minimum to CI.
This also fixes the one source syntax issue that Python 3.10 rejects: a nested f-string expression in
cli.pythat used an escaped quote. The output text is unchanged, but the expression is now built before the outer f-string.Fixes #7.
Changes
requires-python = ">=3.10"._print_claude_summaryparse under Python 3.10.Validation
src,tests, andpackagingwithast.parse(..., feature_version=(3, 10)).python -m compileall -q src tests packagingpytest -q tests/test_init.py::test_init_from_claude_md_creates_derived_rules tests/test_init.py::test_rules_from_claude_md_maps_signals_by_language tests/test_init.py::test_init_from_claude_md_composes_with_baseline tests/test_mcp.py::test_propose_rules_from_claude_mdbecwright check --all(blocking rules passed; existing warning-only comment findings remain warnings)git diff --checkI also ran the full local suite with Python 3.11 on Windows:
Result:
275 passed, 13 failed. The failures appear to be existing Windows/POSIX-shell assumptions in tests and check commands, for examplePYTHONPATH=...,true, andsleepbeing interpreted bycmd.exe. Coverage still reached 93.22%.Summary by CodeRabbit
New Features
pipx install becwrightwith Python 3.10 or newer.Bug Fixes
Documentation