⚗️[MFE] Source code context event enrichment

packages/core/src/tools/experimentalFeatures.ts

@@ -20,6 +20,7 @@ export enum ExperimentalFeature {
   SHORT_SESSION_INVESTIGATION = 'short_session_investigation',
   AVOID_FETCH_KEEPALIVE = 'avoid_fetch_keepalive',
   USE_CHANGE_RECORDS = 'use_change_records',
+  SOURCE_CODE_CONTEXT = 'source_code_context',
 }
 
 const enabledExperimentalFeatures: Set<ExperimentalFeature> = new Set()

packages/core/src/tools/stackTrace/capturedExceptions.specHelper.ts

@@ -247,6 +247,13 @@ export const CHROME_111_SNIPPET = {
 at snippet:///snippet_file:1:13`,
 }
 
+export const CHROME_141_HTML_ANONYMOUS_LISTENER = {
+  message: 'message string',
+  name: 'Error',
+  stack: `Error: message string
+at HTMLButtonElement.<anonymous> @  http://path/to/file.js:1:4287`,
+}
+
 export const PHANTOMJS_1_19 = {
   stack: `Error: foo
     at file:///path/to/file.js:878

packages/core/src/tools/stackTrace/computeStackTrace.spec.ts

@@ -1,5 +1,6 @@
 import { isSafari } from '../utils/browserDetection'
 import * as CapturedExceptions from './capturedExceptions.specHelper'
+import { CHROME_141_HTML_ANONYMOUS_LISTENER } from './capturedExceptions.specHelper'
 import { computeStackTrace } from './computeStackTrace'
 
 describe('computeStackTrace', () => {
@@ -1004,4 +1005,17 @@ Error: foo
       column: undefined,
     })
   })
+
+  it('should parse stack from html button click listener', () => {
+    const stackFrames = computeStackTrace(CHROME_141_HTML_ANONYMOUS_LISTENER)
+
+    expect(stackFrames.stack.length).toEqual(1)
+    expect(stackFrames.stack[0]).toEqual({
+      args: [],
+      column: 4287,
+      func: 'HTMLButtonElement.<anonymous>',
+      line: 1,
+      url: 'http://path/to/file.js',
+    })
+  })
 })

packages/core/src/tools/stackTrace/computeStackTrace.ts

@@ -113,7 +113,11 @@ function parseChromeLine(line: string): StackFrame | undefined {
   }
 }
 
-const CHROME_ANONYMOUS_FUNCTION_RE = new RegExp(`^\\s*at ?${fileUrl}${filePosition}?${filePosition}??\\s*$`, 'i')
+const htmlAnonymousPart = '(?:(.*)?(?: @))'
+const CHROME_ANONYMOUS_FUNCTION_RE = new RegExp(
+  `^\\s*at\\s*${htmlAnonymousPart}?\\s*${fileUrl}${filePosition}?${filePosition}??\\s*$`,
+  'i'
+)
 
 function parseChromeAnonymousLine(line: string): StackFrame | undefined {
   const parts = CHROME_ANONYMOUS_FUNCTION_RE.exec(line)
@@ -124,10 +128,10 @@ function parseChromeAnonymousLine(line: string): StackFrame | undefined {
 
   return {
     args: [],
-    column: parts[3] ? +parts[3] : undefined,
-    func: UNKNOWN_FUNCTION,
-    line: parts[2] ? +parts[2] : undefined,
-    url: parts[1],
+    column: parts[4] ? +parts[4] : undefined,
+    func: parts[1] || UNKNOWN_FUNCTION,
+    line: parts[3] ? +parts[3] : undefined,
+    url: parts[2],
   }
 }
 

packages/rum-core/src/boot/startRum.ts

@@ -55,6 +55,7 @@ import type { Hooks } from '../domain/hooks'
 import { createHooks } from '../domain/hooks'
 import { startEventCollection } from '../domain/event/eventCollection'
 import { startInitialViewMetricsTelemetry } from '../domain/view/viewMetrics/startInitialViewMetricsTelemetry'
+import { startSourceCodeContext } from '../domain/contexts/sourceCodeContext'
 import type { RecorderApi, ProfilerApi } from './rumPublicApi'
 
 export type StartRum = typeof startRum
@@ -230,6 +231,9 @@ export function startRumEventCollection(
     viewHistory,
     initialViewOptions
   )
+
+  startSourceCodeContext(hooks)
+
   cleanupTasks.push(stopViewCollection)
 
   const { stop: stopResourceCollection } = startResourceCollection(lifeCycle, configuration, pageStateHistory)

packages/rum-core/src/domain/action/actionCollection.spec.ts

@@ -6,7 +6,7 @@ import type { RawRumActionEvent, RawRumEvent } from '../../rawRumEvent.types'
 import { RumEventType, ActionType } from '../../rawRumEvent.types'
 import type { RawRumEventCollectedData } from '../lifeCycle'
 import { LifeCycle, LifeCycleEventType } from '../lifeCycle'
-import type { DefaultTelemetryEventAttributes, Hooks } from '../hooks'
+import type { AssembleHookParams, DefaultTelemetryEventAttributes, Hooks } from '../hooks'
 import { createHooks } from '../hooks'
 import type { RumMutationRecord } from '../../browser/domMutationObservable'
 import type { ActionContexts } from './actionCollection'
@@ -174,7 +174,7 @@ describe('actionCollection', () => {
         const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
           eventType,
           startTime: 0 as RelativeTime,
-        })
+        } as AssembleHookParams)
 
         expect(defaultRumEventAttributes).toEqual({ type: eventType, action: { id: actionId } })
       })
@@ -186,7 +186,7 @@ describe('actionCollection', () => {
         const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
           eventType,
           startTime: 0 as RelativeTime,
-        })
+        } as AssembleHookParams)
 
         expect(defaultRumEventAttributes).toEqual(undefined)
       })
@@ -200,7 +200,7 @@ describe('actionCollection', () => {
         eventType: RumEventType.LONG_TASK,
         startTime: longTaskStartTime,
         duration: 50 as Duration,
-      })
+      } as AssembleHookParams)
 
       const [correctedStartTime] = findActionIdSpy.calls.mostRecent().args
       expect(correctedStartTime).toEqual(addDuration(longTaskStartTime, LONG_TASK_START_TIME_CORRECTION))

packages/rum-core/src/domain/assembly.ts

@@ -16,7 +16,7 @@ import { LifeCycleEventType } from './lifeCycle'
 import type { RumConfiguration } from './configuration'
 import type { ModifiableFieldPaths } from './limitModification'
 import { limitModification } from './limitModification'
-import type { Hooks } from './hooks'
+import type { Hooks, AssembleHookParams } from './hooks'
 
 const VIEW_MODIFIABLE_FIELD_PATHS: ModifiableFieldPaths = {
   'view.name': 'string',
@@ -95,9 +95,11 @@ export function startRumAssembly(
     ({ startTime, duration, rawRumEvent, domainContext }) => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: rawRumEvent.type,
+        rawRumEvent,
+        domainContext,
         startTime,
         duration,
-      })!
+      } as AssembleHookParams)!
 
       if (defaultRumEventAttributes === DISCARDED) {
         return

packages/rum-core/src/domain/contexts/ciVisibilityContext.spec.ts

@@ -3,7 +3,7 @@ import { HookNames, Observable } from '@datadog/browser-core'
 import { mockCiVisibilityValues } from '../../../test'
 import type { CookieObservable } from '../../browser/cookieObservable'
 import { SessionType } from '../rumSessionManager'
-import type { Hooks } from '../hooks'
+import type { AssembleHookParams, Hooks } from '../hooks'
 import { createHooks } from '../hooks'
 import { startCiVisibilityContext } from './ciVisibilityContext'
 
@@ -29,7 +29,7 @@ describe('startCiVisibilityContext', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toEqual({
         type: 'view',
@@ -49,7 +49,7 @@ describe('startCiVisibilityContext', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toEqual({
         type: 'view',
@@ -70,7 +70,7 @@ describe('startCiVisibilityContext', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toEqual({
         type: 'view',
@@ -90,7 +90,7 @@ describe('startCiVisibilityContext', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toBeUndefined()
     })
@@ -102,7 +102,7 @@ describe('startCiVisibilityContext', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toBeUndefined()
     })

packages/rum-core/src/domain/contexts/connectivityContext.spec.ts

@@ -1,7 +1,7 @@
 import { setNavigatorOnLine, setNavigatorConnection } from '@datadog/browser-core/test'
 import { HookNames } from '@datadog/browser-core'
 import type { RelativeTime } from '@datadog/browser-core'
-import type { Hooks } from '../hooks'
+import type { AssembleHookParams, Hooks } from '../hooks'
 import { createHooks } from '../hooks'
 import { startConnectivityContext } from './connectivityContext'
 
@@ -17,7 +17,10 @@ describe('startConnectivityContext', () => {
       startConnectivityContext(hooks)
       setNavigatorOnLine(true)
       setNavigatorConnection({ effectiveType: '2g' })
-      const event = hooks.triggerHook(HookNames.Assemble, { eventType: 'view', startTime: 0 as RelativeTime })
+      const event = hooks.triggerHook(HookNames.Assemble, {
+        eventType: 'view',
+        startTime: 0 as RelativeTime,
+      } as AssembleHookParams)
 
       expect(event).toEqual({
         type: 'view',

packages/rum-core/src/domain/contexts/defaultContext.spec.ts

@@ -2,7 +2,7 @@ import { mockClock, mockEventBridge } from '@datadog/browser-core/test'
 import { HookNames, timeStampNow } from '@datadog/browser-core'
 import type { RelativeTime } from '@datadog/browser-core'
 import { mockRumConfiguration } from '../../../test'
-import type { DefaultRumEventAttributes, DefaultTelemetryEventAttributes, Hooks } from '../hooks'
+import type { AssembleHookParams, DefaultRumEventAttributes, DefaultTelemetryEventAttributes, Hooks } from '../hooks'
 import { createHooks } from '../hooks'
 import { startDefaultContext } from './defaultContext'
 
@@ -20,7 +20,7 @@ describe('startDefaultContext', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toEqual({
         type: 'view',
@@ -41,14 +41,14 @@ describe('startDefaultContext', () => {
       const eventWithoutEventBridge = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      }) as DefaultRumEventAttributes
+      } as AssembleHookParams) as DefaultRumEventAttributes
 
       mockEventBridge()
 
       const eventWithEventBridge = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      }) as DefaultRumEventAttributes
+      } as AssembleHookParams) as DefaultRumEventAttributes
 
       expect(eventWithEventBridge._dd!.browser_sdk_version).toBeDefined()
       expect(eventWithoutEventBridge._dd!.browser_sdk_version).toBeUndefined()
@@ -64,7 +64,7 @@ describe('startDefaultContext', () => {
       const event = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      }) as DefaultRumEventAttributes
+      } as AssembleHookParams) as DefaultRumEventAttributes
 
       expect(event._dd!.configuration!.session_sample_rate).toBe(10)
       expect(event._dd!.configuration!.session_replay_sample_rate).toBe(20)

packages/rum-core/src/domain/contexts/displayContext.spec.ts

@@ -1,7 +1,7 @@
 import { HookNames } from '@datadog/browser-core'
 import type { RelativeTime } from '@datadog/browser-core'
 import { mockRumConfiguration } from '../../../test'
-import type { Hooks } from '../hooks'
+import type { AssembleHookParams, Hooks } from '../hooks'
 import { createHooks } from '../hooks'
 import type { DisplayContext } from './displayContext'
 import { startDisplayContext } from './displayContext'
@@ -27,7 +27,10 @@ describe('displayContext', () => {
     it('should set the display context', () => {
       displayContext = startDisplayContext(hooks, mockRumConfiguration())
 
-      const event = hooks.triggerHook(HookNames.Assemble, { eventType: 'view', startTime: 0 as RelativeTime })
+      const event = hooks.triggerHook(HookNames.Assemble, {
+        eventType: 'view',
+        startTime: 0 as RelativeTime,
+      } as AssembleHookParams)
       expect(requestAnimationFrameSpy).toHaveBeenCalledTimes(1)
 
       expect(event).toEqual({

packages/rum-core/src/domain/contexts/featureFlagContext.spec.ts

@@ -6,7 +6,7 @@ import { LifeCycle, LifeCycleEventType } from '../lifeCycle'
 import type { ViewCreatedEvent, ViewEndedEvent } from '../view/trackViews'
 import type { RumConfiguration } from '../configuration'
 import { RumEventType } from '../../rawRumEvent.types'
-import type { Hooks } from '../hooks'
+import type { AssembleHookParams, Hooks } from '../hooks'
 import { createHooks } from '../hooks'
 import type { FeatureFlagContexts } from './featureFlagContext'
 import { startFeatureFlagContexts } from './featureFlagContext'
@@ -38,11 +38,11 @@ describe('featureFlagContexts', () => {
       const defaultViewAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
       const defaultErrorAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'error',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultViewAttributes).toEqual({
         type: 'view',
@@ -70,7 +70,7 @@ describe('featureFlagContexts', () => {
         const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
           eventType,
           startTime: 0 as RelativeTime,
-        })
+        } as AssembleHookParams)
 
         expect(defaultRumEventAttributes).toEqual({
           type: eventType,
@@ -94,7 +94,7 @@ describe('featureFlagContexts', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toEqual({
         type: 'view',
@@ -127,11 +127,11 @@ describe('featureFlagContexts', () => {
       const defaultEventOneAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 5 as RelativeTime,
-      })
+      } as AssembleHookParams)
       const defaultEventTwoAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 15 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultEventOneAttributes).toEqual({ type: 'view', feature_flags: { feature: 'one' } })
       expect(defaultEventTwoAttributes).toEqual({ type: 'view', feature_flags: { feature: 'two' } })
@@ -149,7 +149,7 @@ describe('featureFlagContexts', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toBeUndefined()
     })
@@ -166,7 +166,7 @@ describe('featureFlagContexts', () => {
       const defaultRumEventAttributes = hooks.triggerHook(HookNames.Assemble, {
         eventType: 'view',
         startTime: 0 as RelativeTime,
-      })
+      } as AssembleHookParams)
 
       expect(defaultRumEventAttributes).toEqual({ type: 'view', feature_flags: { feature: 'bar', feature2: 'baz' } })
     })