[Profiling] Add action and vital metadata to profiles#4148
Draft
MandragoreVR wants to merge 2 commits intomainfrom
Draft
[Profiling] Add action and vital metadata to profiles#4148MandragoreVR wants to merge 2 commits intomainfrom
MandragoreVR wants to merge 2 commits intomainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory PerformancePending... |
ac613af to
59aa5b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To enable profiling aggregation on the backend for vitals and actions, we want to add vitals and actions data to the metadata of profiling events.
This PR adds these entries to the profiling events metadata. It relies on this PR from rum-events-format to be merged.
Changes
SESSION_TIME_OUT_DELAYTest instructions
sandbox/react-app/main.tsx, add:to the SDK configuration, and add
before the
returnof theLayoutfunction to have a vital that will be displayed in the collected ones.yarn devand go tolocalhost:8080/react-apphttps://browser-intake-datadoghq.com/api/v2/profilein the network tab (profiles usually last one minute, so this might not come instantly, but you can also edit the constantcollectIntervalMsinprofiler.tsto make it faster)"action"and"vital", both with an object of the shape{ "id": string[], "label": string[] }"action"and"vitals"with the following shape:Checklist