Revert "Revert "update ECS fargate collector to use v4 endpoint""

[kangyili]

Reverts #24914

The original PR broke CI on main so it was reverted. It is because I accidentally deleted the code initialising ecs clients during refactoring, this PR adds it back...

[kangyili]

Nothing has changed except the addition of code to initialize the client 9f17b62

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=32673841 --os-family=ubuntu

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 84549f8d-f1c3-4a99-918c-0cc016f3dbb1
Baseline: 43582fd
Comparison: aecc80c

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	file_to_blackhole	% cpu utilization	+104.84	[+93.62, +116.06]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	file_to_blackhole	% cpu utilization	+104.84	[+93.62, +116.06]
➖	tcp_syslog_to_blackhole	ingress throughput	+9.64	[-12.74, +32.01]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.27	[-1.70, +4.24]
➖	process_agent_standard_check	memory utilization	+0.62	[+0.56, +0.68]
➖	idle	memory utilization	+0.52	[+0.48, +0.57]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.00	[-0.01, +0.01]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.02	[-0.06, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.22, +0.19]
➖	otel_to_otel_logs	ingress throughput	-0.09	[-0.45, +0.26]
➖	process_agent_standard_check_with_stats	memory utilization	-0.19	[-0.24, -0.13]
➖	process_agent_real_time_mode	memory utilization	-0.52	[-0.57, -0.47]
➖	basic_py_check	% cpu utilization	-1.04	[-3.50, +1.41]
➖	pycheck_1000_100byte_tags	% cpu utilization	-2.36	[-6.97, +2.25]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[kangyili]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

[kangyili]

/merge -c

[dd-devflow]

⚠️ MergeQueue

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

[kangyili]

It's hard to have an e2e test for an internal component as it doesn't send data directly.
I will open another PR to add an e2e test for the check orchestrator_ecs that uses workload-meta store.

[kangyili]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!