merge 3 ecs feature flags to 1

[kangyili]

What does this PR do?

Currently users need to set three feature flags to enable ecs task collection.

• DD_CONTAINER_LIFECYCLE_ECS_TASK_EVENT_ENABLED
• DD_ORCHESTRATOR_EXPLORER_ECS_COLLECTION_ENABLED
• DD_ECS_TASK_COLLECTION_ENABLED

This PR deletes first 2 feature flags and update agent to only rely on the last one to simplify the setup.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Create an ECS Cluster and Deploy the Datadog Agent:

Set up an ECS cluster and deploy the Datadog agent.
Update the agent's task definition by adding the following environment variables:

{
"name": "DD_ECS_TASK_COLLECTION_ENABLED",
"value": "true"
},

Verify Agent:

Ensure the agent is correctly sending task payloads.
Use the agent status command to check and confirm the number of tasks being sent.

[mfpierre]

LGTM but just want to make sure that ecs_task_collection_enabled will not be used independently from the orchestrator collection

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=40432277 --os-family=ubuntu

Note: This applies to commit 2015b24

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 3e5201f0-bc5b-4331-8880-9c1692a81b38 Metrics dashboard Target profiles

Baseline: 2f0feed
Comparison: 2015b24

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+6.30	[-6.94, +19.54]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.96	[+0.06, +1.85]	Logs
➖	idle	memory utilization	+0.31	[+0.27, +0.34]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	file_tree	memory utilization	-0.53	[-0.59, -0.46]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.67	[-1.48, +0.14]	Logs
➖	basic_py_check	% cpu utilization	-1.07	[-3.66, +1.52]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-4.86	[-9.43, -0.29]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[kangyili]

LGTM but just want to make sure that ecs_task_collection_enabled will not be used independently from the orchestrator collection

Yes, currently only orchestrator collection needs ecs_task_collection_enabled. We can set this flag to true in the feature

This feature flag is introduced by #21836

[kangyili]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!