CAP-1832 update config template#28582
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=42390693 --os-family=ubuntuNote: This applies to commit 82262ab |
Regression DetectorRegression Detector ResultsRun ID: 15a5c331-4148-4972-a321-f839456afb19 Metrics dashboard Target profiles Baseline: 77b9014 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +4.55 | [-8.75, +17.85] | Logs |
| ➖ | file_tree | memory utilization | +0.66 | [+0.58, +0.74] | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.63 | [-0.17, +1.44] | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | +0.22 | [-2.27, +2.70] | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
| ➖ | idle | memory utilization | -0.44 | [-0.47, -0.41] | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.54 | [-3.23, +2.16] | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.62 | [-1.41, +0.18] | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
rtrieu
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise looks good!
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
ecs_task_collection_enabledis introduced by Update Workloadmeta ECS collector to use metadata v4 endpoint #21836 and it's an option to enable detailed task collection for orchestrator ecs checkMotivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes