Skip to content

CAP-1832 update config template#28582

Merged
dd-mergequeue[bot] merged 2 commits intomainfrom
kangyi/ecs-config-template
Aug 21, 2024
Merged

CAP-1832 update config template#28582
dd-mergequeue[bot] merged 2 commits intomainfrom
kangyi/ecs-config-template

Conversation

@kangyili
Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@kangyili kangyili requested review from a team as code owners August 20, 2024 12:51
@kangyili kangyili modified the milestones: 7.57.0, 7.58.0 Aug 20, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Aug 20, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42390693 --os-family=ubuntu

Note: This applies to commit 82262ab

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Aug 20, 2024

Regression Detector

Regression Detector Results

Run ID: 15a5c331-4148-4972-a321-f839456afb19 Metrics dashboard Target profiles

Baseline: 77b9014
Comparison: 82262ab

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +4.55 [-8.75, +17.85] Logs
file_tree memory utilization +0.66 [+0.58, +0.74] Logs
otel_to_otel_logs ingress throughput +0.63 [-0.17, +1.44] Logs
pycheck_lots_of_tags % cpu utilization +0.22 [-2.27, +2.70] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
idle memory utilization -0.44 [-0.47, -0.41] Logs
basic_py_check % cpu utilization -0.54 [-3.23, +2.16] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.62 [-1.41, +0.18] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Copy Markdown
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, otherwise looks good!

Comment thread pkg/config/config_template.yaml Outdated
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@kangyili
Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow bot commented Aug 21, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link
Copy Markdown

dd-devflow bot commented Aug 21, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 0dffd30 into main Aug 21, 2024
@dd-mergequeue dd-mergequeue bot deleted the kangyi/ecs-config-template branch August 21, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants