refactor(remote-config): migrate rcservicemrf component to v2#48548
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom Apr 7, 2026
Merged
Conversation
Contributor
Go Package Import DifferencesBaseline: 0f4a90a
|
louis-cqrl
added
qa/done
Contributor
Files inventory check summaryFile checks results against ancestor 0f4a90a2: Results for datadog-agent_7.79.0~devel.git.484.0e2ef2f.pipeline.106489485-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 1764162 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.14 | [-0.85, +5.12] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +2.14 | [-0.85, +5.12] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.42 | [+0.36, +0.48] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.28 | [+0.05, +0.50] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.25 | [+0.16, +0.35] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.21 | [+0.16, +0.26] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.06 | [-0.51, +0.62] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.40, +0.48] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.22] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.20, +0.22] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.10, +0.11] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.00 | [-0.03, +0.04] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.38, +0.39] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.14, +0.07] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.04 | [-0.12, +0.04] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.05 | [-0.19, +0.09] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.27 | [-0.44, -0.11] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.30 | [-0.49, -0.10] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.38 | [-0.44, -0.33] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.44 | [-0.52, -0.37] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.53 | [-0.69, -0.37] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.64 | [-0.87, -0.41] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.80 | [-1.00, -0.60] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.10 | [-2.76, +0.55] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 680 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 274.11MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 588 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.94MiB ≤ 181MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 491.06MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 204.46MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 363.92 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 417.01MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
30 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
2 times, most recently
from
da141ae to
58a0f42
Compare
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
from
58a0f42 to
5f5ccb5
Compare
moth-a
approved these changes
Mar 30, 2026
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
from
5f5ccb5 to
71a4262
Compare
Enzu83
approved these changes
Apr 7, 2026
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
from
2868650 to
004b897
Compare
github-actions
bot
added
long review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 004b897fa0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
from
004b897 to
64db7b0
Compare
github-actions
bot
added
medium review
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
from
64db7b0 to
2b1a80f
Compare
wiyu
approved these changes
Apr 7, 2026
louis-cqrl
force-pushed
the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
from
948435c to
2b1a80f
Compare
gh-worker-dd-mergequeue-cf854d
bot
merged commit 777f105
into
main
277 of 278 checks passed
gh-worker-dd-mergequeue-cf854d
bot
deleted the
louis-cqrl/refactor-remote-config-rcservicemrf-to-v2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates
comp/remote-config/rcservicemrffrom V1 component structure to V2, following the standarddef/impl/fxlayout.component.gotodef/component.go(interface only)rcservicemrfimpl/rcservicemrf.gotoimpl/rcservicemrf.gowith updated package and importsfx/fx.gowithModule()helpercomponent.goandrcservicemrfimpl/directorycomp/remote-config/rcservicemrf/defMotivation
Standardizes the component structure to V2, separating the interface definition from the implementation and fx wiring.
Describe how you validated your changes
CI
Additional Notes
None.