Skip to content

Fix the schema generate for array of int#53744

Open
hush-hush wants to merge 1 commit into
mainfrom
maxime/fix-schema-generation-int-array
Open

Fix the schema generate for array of int#53744
hush-hush wants to merge 1 commit into
mainfrom
maxime/fix-schema-generation-int-array

Conversation

@hush-hush

Copy link
Copy Markdown
Member

What does this PR do?

Fix the schema generate for array of int

@hush-hush
hush-hush requested a review from a team as a code owner July 16, 2026 14:46
@hush-hush
hush-hush requested a review from s-alad July 16, 2026 14:46
@hush-hush hush-hush added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels Jul 16, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 16, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Jul 16, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2ce37fa0a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 560 to +561
items:
type: number
type: integer

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep template generation working for int arrays

When this schema is rendered for system-probe, tasks/schema/template.py only accepts array item types string, object, or number before raising unknown array of type: ...; changing dns_monitoring_ports to items.type: integer therefore makes schema.template-all fail, and dda inv agent.build reaches that path via generate_config_examples for the system-probe template. Please either teach the template renderer about integer arrays or keep the previous representation until all consumers support it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant