[Backport 7.82.x] feat(windows): deliver AI Usage host as EUDM-gated fleet extension#53759
Open
dd-octo-sts[bot] wants to merge 1 commit into
Open
[Backport 7.82.x] feat(windows): deliver AI Usage host as EUDM-gated fleet extension#53759dd-octo-sts[bot] wants to merge 1 commit into
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
…53406) ### What does this PR do? Migrates the Windows **AI Usage Chrome Native Messaging host + desktop monitor** out of the MSI and into a new **`eudm` fleet installer extension** (modeled on `ddot`), installed **only when End User Device Monitoring (EUDM) is enabled**. This is the long-term follow-up to the interim MSI-level EUDM gate (#53289). **Gating** (`installAgentExtensions`): appends the `eudm` extension on Windows when EUDM is signaled via `DD_INFRASTRUCTURE_MODE=end_user_device` **or** `infrastructure_mode: end_user_device` already in `datadog.yaml` (covers upgrades that don't re-pass the env var). The extension is pulled from the `datadog-agent` OCI image's `ai-usage` layer by the post-install hook (`RunPostInstallHook` → `installAgentExtensions`), which already runs on every MSI install/upgrade. **New extension hooks** (`datadog_agent_eudm_windows.go`) reproduce what the MSI custom actions used to do: - copy the native host binary into the Agent's `bin\agent` (user-executable via Program Files ACL inheritance), - write the Chrome host manifest JSON (resolved `chrome_extension_id`, fallback) + the two HKLM `NativeMessagingHosts` registry entries, - register + start the logon-triggered `Datadog AI Usage Agent` scheduled task (`schtasks`, UTF‑16LE XML). - `preRemove` tears all of it down. **MSI strip + migration cleanup:** - Removed the AI Usage binary `File`, both Chrome regkeys, the `WriteConfig` yaml/manifest generation, and the `ConfigureAiUsageMonitorDesktopMonitor` custom action. - Forward `DD_INFRASTRUCTURE_MODE` into `RunPostInstallHook`. **Packaging:** new `//cmd/ai_prompt_logger:install-extension` Bazel target (flat layer layout), removed the omnibus MSI-payload staging, and added `msi.fetch-artifacts --ai-usage` / `msi.package-oci --eudm` (`--extension ai-usage=`). ### Motivation https://datadoghq.atlassian.net/browse/WINA-2867 — AI Usage monitoring should be gated behind EUDM rather than installed unconditionally. The ticket calls for this to become a fleet package (this PR), superseding the interim MSI gate. ### Describe how you validated your changes - Added e2e tests that verify extension installation. - unit tests - manually tested to verify chrome component still works and install causes no issues ### Additional Notes if a machine has old MSI-created AI Usage artifacts but does not install the ai-usage extension, extension hooks never run, so those old artifacts would not be cleaned by this removal. Co-authored-by: jack.phillips <jack.phillips@datadoghq.com> (cherry picked from commit 514a2e1) ___ Co-authored-by: Jack Phillips <jack.phillips@datadoghq.com>
dd-octo-sts
Bot
added
long review
Contributor
Author
Gitlab CI Configuration ChangesModified Jobsvariables (configuration) variables:
AGENT_API_KEY_ORG2: agent-api-key-org-2
AGENT_APP_KEY_ORG2: agent-app-key-org-2
AGENT_BINARIES_DIR: bin/agent
AGENT_QA_E2E: agent-qa-e2e
ARTIFACT_DOWNLOAD_ATTEMPTS: 2
ATLASSIAN_WRITE: atlassian-write
BTFHUB_ARCHIVE_BRANCH: main
BUCKET_BRANCH: dev
CACHE_COMPRESSION_LEVEL: slowest
CHANGELOG_COMMIT_SHA: ci.datadog-agent.gitlab_changelog_commit_sha
- CI_IMAGE_BTF_GEN: v123723142-c6f300a6
+ CI_IMAGE_BTF_GEN: v123467524-627631bf
CI_IMAGE_BTF_GEN_SUFFIX: ''
- CI_IMAGE_DOCKER_ARM64: v123723142-c6f300a6
? ^^^^^ -----
+ CI_IMAGE_DOCKER_ARM64: v123467524-627631bf
? ++ + ++++++ ^
CI_IMAGE_DOCKER_ARM64_SUFFIX: ''
- CI_IMAGE_DOCKER_X64: v123723142-c6f300a6
? ^^^^^ -----
+ CI_IMAGE_DOCKER_X64: v123467524-627631bf
? ++ + ++++++ ^
CI_IMAGE_DOCKER_X64_SUFFIX: ''
- CI_IMAGE_GITLAB_AGENT_DEPLOY: v123723142-c6f300a6
? ^^^^^ -----
+ CI_IMAGE_GITLAB_AGENT_DEPLOY: v123467524-627631bf
? ++ + ++++++ ^
CI_IMAGE_GITLAB_AGENT_DEPLOY_SUFFIX: ''
- CI_IMAGE_LINUX: v123723142-c6f300a6
+ CI_IMAGE_LINUX: v123467524-627631bf
CI_IMAGE_LINUX_SUFFIX: ''
- CI_IMAGE_RPM_ARM64: v123723142-c6f300a6
? ^^^^^ -----
+ CI_IMAGE_RPM_ARM64: v123467524-627631bf
? ++ + ++++++ ^
CI_IMAGE_RPM_ARM64_SUFFIX: ''
- CI_IMAGE_RPM_ARMHF: v123723142-c6f300a6
? ^^^^^ -----
+ CI_IMAGE_RPM_ARMHF: v123467524-627631bf
? ++ + ++++++ ^
CI_IMAGE_RPM_ARMHF_SUFFIX: ''
- CI_IMAGE_RPM_X64: v123723142-c6f300a6
+ CI_IMAGE_RPM_X64: v123467524-627631bf
CI_IMAGE_RPM_X64_SUFFIX: ''
- CI_IMAGE_WIN_LTSC2022_X64: v123723142-c6f300a6
? ^^^^ ^ ^^^^^
+ CI_IMAGE_WIN_LTSC2022_X64: v120143276-cb5277fb
? ^ + ++ ^^^^^ ^
CI_IMAGE_WIN_LTSC2022_X64_SUFFIX: ''
- CI_IMAGE_WIN_LTSC2025_X64: v123723142-c6f300a6
? ^^^^ ^ ^^^^^
+ CI_IMAGE_WIN_LTSC2025_X64: v120143276-cb5277fb
? ^ + ++ ^^^^^ ^
CI_IMAGE_WIN_LTSC2025_X64_SUFFIX: ''
CLANG_BUILD_VERSION: v60409452-ee70de70
CLANG_LLVM_VER: 12.0.1
CLUSTER_AGENT_BINARIES_DIR: bin/datadog-cluster-agent
CLUSTER_AGENT_CLOUDFOUNDRY_BINARIES_DIR: bin/datadog-cluster-agent-cloudfoundry
CODECOV: codecov
- COMPARE_TO_BRANCH: main
? ^^^^
+ COMPARE_TO_BRANCH: 7.82.x
? ^^^^^^
CRC_PULL_SECRET: ci.datadog-agent.crc-pull-secret
CWS_INSTRUMENTATION_BINARIES_DIR: bin/cws-instrumentation
DATADOG_AGENT_EMBEDDED_PATH: /opt/datadog-agent/embedded
DDA_CLIENT_TOKEN: dda-feature-flags-client-token
DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS: ci.datadog-agent.dda-feature-flags-client-token
DDA_FEATURE_FLAGS_CI_VAULT_KEY: token
DDA_FEATURE_FLAGS_CI_VAULT_KEY_MACOS: token
DDA_FEATURE_FLAGS_CI_VAULT_PATH: k8s/gitlab-runner-datadog-agent/datadog-agent/$DDA_CLIENT_TOKEN
DDA_FEATURE_FLAGS_CI_VAULT_PATH_MACOS: aws/arn:aws:iam::486234852809:role/ci-datadog-agent/$DDA_CLIENT_TOKEN
DD_AGENT_TESTING_DIR: $CI_PROJECT_DIR/test/new-e2e/tests
DD_PKG_GITLAB_URL: https://artifact-gateway.us1.ddbuild.io/internal/artifact-gateway/api/v4
DEB_GPG_KEY_ID: c0962c7d
DEB_GPG_KEY_NAME: Datadog, Inc. APT key
DEB_RPM_TESTING_BUCKET_BRANCH: testing
DEB_S3_BUCKET: apt.datad0g.com
DEB_TESTING_S3_BUCKET: apttesting.datad0g.com
DISABLE_GIT_CACHE: true
DOCKER_REGISTRY_RO: dockerhub-readonly
DOCKER_REGISTRY_URL: docker.io
DOGSTATSD_BINARIES_DIR: bin/dogstatsd
DYNAMIC_TESTS_BREAKGLASS: dynamic-tests-breakglass
E2E_AZURE: e2e-azure
E2E_COVERAGE_PIPELINE: false
E2E_GCP: e2e-gcp
EXECUTOR_JOB_SECTION_ATTEMPTS: 2
FF_CLEAN_UP_FAILED_CACHE_EXTRACT: true
FF_KUBERNETES_HONOR_ENTRYPOINT: true
FF_SCRIPT_SECTIONS: 1
FF_TIMESTAMPS: true
FF_USE_FASTZIP: true
FF_USE_WINDOWS_JOB_OBJECT: true
GENERAL_ARTIFACTS_CACHE_BUCKET_URL: https://dd-agent-omnibus.s3.amazonaws.com
GET_SOURCES_ATTEMPTS: 2
GIT_STRATEGY: fetch
GO_TEST_SKIP_FLAKE: 'true'
GPG_TEST_KEY_ID: crypto/k8s/keys/k8s_gitlab-runner-datadog-agent_datadog-agent_testing_signing-key
INSTALLER_TESTING_S3_BUCKET: installtesting.datad0g.com
INSTALL_SCRIPT_API_KEY_ORG2: install-script-api-key-org-2
KERNEL_MATRIX_TESTING_ARM_AMI_ID: ami-0b5f838a19d37fc61
KERNEL_MATRIX_TESTING_X86_AMI_ID: ami-05b3973acf5422348
KITCHEN_INFRASTRUCTURE_FLAKES_RETRY: 2
MACOS_APPLE_APPLICATION_SIGNING: apple-application-signing
MACOS_APPLE_DEVELOPER_ACCOUNT: apple-developer-account
MACOS_APPLE_INSTALLER_SIGNING: apple-installer-signing
MACOS_KEYCHAIN_PWD: ci-keychain
MACOS_S3_BUCKET: dd-agent-macostesting
OMNIBUS_BASE_DIR: /omnibus
OMNIBUS_GIT_CACHE_DIR: /tmp/omnibus-git-cache
OMNIBUS_PACKAGE_DIR: $CI_PROJECT_DIR/omnibus/pkg/
OMNIBUS_PACKAGE_DIR_SUSE: $CI_PROJECT_DIR/omnibus/suse/pkg
PIPELINE_KEY_ALIAS: alias/ci_datadog-agent_pipeline-key
PROCESS_S3_BUCKET: datad0g-process-agent
PYTHONUNBUFFERED: 1
RESTORE_CACHE_ATTEMPTS: 2
RPM_GPG_KEY_ID: b01082d3
RPM_GPG_KEY_NAME: Datadog, Inc. RPM key
RPM_S3_BUCKET: yum.datad0g.com
RPM_TESTING_S3_BUCKET: yumtesting.datad0g.com
RUN_E2E_TESTS: auto
RUN_KMT_TESTS: auto
RUN_UNIT_TESTS: auto
S3_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME/$CI_PIPELINE_ID
S3_CP_CMD: aws s3 cp $S3_CP_OPTIONS
S3_CP_OPTIONS: --no-progress --region us-east-1 --sse AES256
S3_DD_AGENT_OMNIBUS_BTFS_URI: s3://dd-agent-omnibus/btfs
S3_DD_AGENT_OMNIBUS_JAVA_URI: s3://dd-agent-omnibus/openjdk
S3_DD_AGENT_OMNIBUS_LLVM_URI: s3://dd-agent-omnibus/llvm
S3_DSD6_URI: s3://dsd6-staging
S3_OMNIBUS_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-cache-build-stable
S3_OMNIBUS_GIT_CACHE_BUCKET: dd-ci-datadog-agent-omnibus-git-cache-build-stable
S3_PERMANENT_ARTIFACTS_URI: s3://dd-ci-persistent-artefacts-build-stable/$CI_PROJECT_NAME
S3_PROJECT_ARTIFACTS_URI: s3://dd-ci-artefacts-build-stable/$CI_PROJECT_NAME
S3_RELEASE_ARTIFACTS_URI: s3://dd-release-artifacts/$CI_PROJECT_NAME/$CI_PIPELINE_ID
S3_RELEASE_INSTALLER_ARTIFACTS_URI: s3://dd-release-artifacts/datadog-installer/$CI_PIPELINE_ID
S3_SBOM_STORAGE_URI: s3://sbom-root-us1-ddbuild-io/$CI_PROJECT_NAME/$CI_PIPELINE_ID
SECRET_GENERIC_CONNECTOR_BINARIES_DIR: bin/secret-generic-connector
SKIP_WINDOWS: 'false'
SLACK_AGENT: slack-agent-ci
SMP_ACCOUNT: smp
STATIC_BINARIES_DIR: bin/static
SYSTEM_PROBE_BINARIES_DIR: bin/system-probe
TEST_KEYS_URL: apttesting.datad0g.com/test-keys
VCPKG_BLOB_SAS_URL: vcpkg-blob-sas
VIRUS_TOTAL: virus-total
WINDOWS_BUILDS_S3_BUCKET: $WIN_S3_BUCKET/builds
WINDOWS_POWERSHELL_DIR: $CI_PROJECT_DIR/signed_scripts
WINDOWS_SYMBOLS_S3_BUCKET: pipelines/windows-symbols
WINDOWS_TESTING_S3_BUCKET: pipelines/A7/$CI_PIPELINE_ID
WINGET_PAT: winget-pat
WIN_S3_BUCKET: dd-agent-mstestingagent_win_oci agent_win_oci:
artifacts:
expire_in: 2 weeks
paths:
- ${OMNIBUS_PACKAGE_DIR}/pipeline-$CI_PIPELINE_ID
before_script:
- PACKAGE_VERSION="$(dda inv agent.version --url-safe)-1" || exit $?
- export INSTALL_DIR=${INSTALL_DIR:-/opt/datadog-packages/${OCI_PRODUCT}/${PACKAGE_VERSION}}
- set +x
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
needs:
- artifacts: true
job: windows_msi_and_bosh_zip_x64-a7
- artifacts: true
job: windows_zip_ddot_x64
+ - artifacts: true
+ job: windows_zip_eudm_x64
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- "set -euo pipefail\nPIPE_DIR=\"$OMNIBUS_PACKAGE_DIR/pipeline-$CI_PIPELINE_ID\"\
\nARTIFACT=$(ls -1 \"${PIPE_DIR}\"/${WIN_ARTIFACT_PATTERN} 2>/dev/null)\nif [\
\ -z \"$ARTIFACT\" ]; then\n echo \"No suitable input artifact found\"; exit\
\ 1\nfi\nif [ \"$(echo \"$ARTIFACT\" | wc -l)\" != 1 ]; then\n echo \"Expected\
\ exactly one candidate input artifact\"; exit 1\nfi\nif [ -z \"${PACKAGE_VERSION:-}\"\
\ ]; then\n echo \"PACKAGE_VERSION is not set\"; exit 1\nfi\n"
- 'SRC_DIR="$(mktemp -d)"
EXTRA_FLAGS=""
cp "${ARTIFACT}" "${SRC_DIR}/"
'
- "DDOT_ARTIFACT=$(ls -1 \"${PIPE_DIR}\"/datadog-agent-ddot-*x86_64.zip 2>/dev/null\
\ || true)\nif [ -n \"$DDOT_ARTIFACT\" ]; then\n DDOT_INPUT_DIR=\"$(mktemp -d)\"\
\n DDOT_EXTENSION_DIR=\"$(mktemp -d)\"\n echo \"Extracting DDOT to ${DDOT_INPUT_DIR}\"\
\n unzip -q \"${DDOT_ARTIFACT}\" -d \"${DDOT_INPUT_DIR}\"\n\n # Copy entire\
\ DDOT structure to extension directory\n cp -r \"${DDOT_INPUT_DIR}\"/* \"${DDOT_EXTENSION_DIR}\"\
/\n\n EXTRA_FLAGS=\"${EXTRA_FLAGS} --extension ddot=${DDOT_EXTENSION_DIR}\"\n\
fi\n"
+ - "EUDM_ARTIFACT=$(ls -1 \"${PIPE_DIR}\"/datadog-agent-eudm-*x86_64.zip 2>/dev/null\
+ \ || true)\nif [ -n \"$EUDM_ARTIFACT\" ]; then\n EUDM_INPUT_DIR=\"$(mktemp -d)\"\
+ \n EUDM_EXTENSION_DIR=\"$(mktemp -d)\"\n echo \"Extracting EUDM extension to\
+ \ ${EUDM_INPUT_DIR}\"\n unzip -q \"${EUDM_ARTIFACT}\" -d \"${EUDM_INPUT_DIR}\"\
+ \n\n # Copy entire EUDM extension structure (flat: AI Usage host binary + example\
+ \ config) to extension directory\n cp -r \"${EUDM_INPUT_DIR}\"/* \"${EUDM_EXTENSION_DIR}\"\
+ /\n\n EXTRA_FLAGS=\"${EXTRA_FLAGS} --extension eudm=${EUDM_EXTENSION_DIR}\"\n\
+ fi\n"
- "INSTALLER_BIN=$(ls -1 \"${PIPE_DIR}\"/datadog-installer-*-x86_64.exe 2>/dev/null\
\ | head -1)\nif [ -n \"$INSTALLER_BIN\" ]; then\n EXTRA_FLAGS=\"${EXTRA_FLAGS}\
\ --installer ${INSTALLER_BIN}\"\nelse\n echo \"ERROR: No installer binary found\
\ for datadog-agent OCI package\"\n exit 1\nfi\n"
- export PATH="$PATH:$(go env GOPATH)/bin"
- datadog-package create --version "${PACKAGE_VERSION}" --package "${OCI_PRODUCT}"
--os windows --arch amd64 --archive --archive-path "${PIPE_DIR}/${OCI_PRODUCT}-${PACKAGE_VERSION}-windows-amd64.oci.tar"
${EXTRA_FLAGS} "${SRC_DIR}/"
- ls -l "${PIPE_DIR}"
stage: packaging
tags:
- arch:amd64
- specific:true
variables:
KUBERNETES_CPU_REQUEST: 16
KUBERNETES_MEMORY_LIMIT: 32Gi
KUBERNETES_MEMORY_REQUEST: 32Gi
OCI_PRODUCT: datadog-agent
WIN_ARTIFACT_PATTERN: datadog-agent-[0-9]*-x86_64.msi
WIN_SOURCE_TYPE: msiAdded Jobs.windows_zip_bazel_base.windows_zip_bazel_base:
artifacts:
expire_in: 2 weeks
paths:
- omnibus/pkg/pipeline-$CI_PIPELINE_ID
before_script:
- C:\ci-identities-gitlab-job-client.exe assume-role
id_tokens:
BUILDBARN_ID_TOKEN:
aud: buildbarn.us1.ddbuild.io
CI_IDENTITIES_GITLAB_ID_TOKEN:
aud: ci-identities
needs:
- go_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- $ErrorActionPreference = "Stop"
- . ./tools/ci/sanitize-goproxy.ps1
- if (Test-Path omnibus\pkg) { remove-item -recurse -force omnibus\pkg }
- mkdir omnibus\pkg
- '.\tools\ci\docker-run-with-bazel-cache.ps1 -m 24576M -v "$(Get-Location):c:\mnt"
-e DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS="${DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS}"
-e GITLAB_CI -e CI_JOB_ID -e CI_PIPELINE_ID -e CI_PROJECT_NAME -e CI_COMMIT_BRANCH
-e CI_JOB_NAME_SLUG -e CI_COMMIT_REF_NAME -e OMNIBUS_TARGET -e WINDOWS_BUILDER=true
-e GOMODCACHE="c:\modcache" -e GOPROXY -e GONOSUMDB -e AWS_NETWORKING=true -e
SIGN_WINDOWS_DD_WCS=true -e WINDOWS_SIGNING_CERT -e WINDOWS_SIGNING_CONFIG -e
TARGET_ARCH="$ARCH" -e BUCKET_BRANCH -e S3_OMNIBUS_CACHE_BUCKET -e S3_OMNIBUS_GIT_CACHE_BUCKET
-e BUNDLE_MIRROR__RUBYGEMS__ORG -e PIP_INDEX_URL -e AGENT_API_KEY_ORG2 -e OMNIBUS_GIT_CACHE_DIR=${Env:TEMP}/${CI_PIPELINE_ID}/omnibus-git-cache
-e AGENT_FLAVOR -e OMNIBUS_RUBY_VERSION -e PYTHONUTF8=1 -e DEPLOY_AGENT -e CI_JOB_TOKEN
-e CI_IDENTITIES_GITLAB_ID_TOKEN ${WINBUILDIMAGE} powershell -C "c:\mnt\tasks\winbuildscripts\Build-OmnibusTarget.ps1
-BuildOutOfSource 1 -InstallDeps 1 -CheckGoVersion 1"
'
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
- get-childitem omnibus\pkg\pipeline-$CI_PIPELINE_ID
- Invoke-Expression "$S3_CP_CMD omnibus\pkg\pipeline-$CI_PIPELINE_ID\version-manifest.json
$S3_SBOM_STORAGE_URI/$CI_JOB_NAME/version-manifest.json"
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
stage: package_build
tags:
- windows-v2:2022
variables:
ARCH: x64
AWS_SHARED_CREDENTIALS_FILE: ${CI_PROJECT_DIR}\.aws\credentials-by-job-id\${CI_JOB_ID}
BAZELISK_HOME: $XDG_CACHE_HOME/bazelisk
GIT_STRATEGY: clone
WINBUILDIMAGE: registry.ddbuild.io/ci/datadog-agent-buildimages/windows_ltsc2022_${ARCH}${CI_IMAGE_WIN_LTSC2022_X64_SUFFIX}:${CI_IMAGE_WIN_LTSC2022_X64}
XDG_CACHE_HOME: c:/bzlnew-e2e-windows-eudm-package-a7-x86_64new-e2e-windows-eudm-package-a7-x86_64:
after_script:
- CODECOV_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $CODECOV token) || exit
$?; export CODECOV_TOKEN
- $CI_PROJECT_DIR/tools/ci/junit_upload.sh "junit-${CI_JOB_ID}.tgz" "$E2E_RESULT_JSON"
- "if [ -d \"$E2E_COVERAGE_OUT_DIR\" ]; then\n dda inv -- -e coverage.process-e2e-coverage-folders\
\ $E2E_COVERAGE_OUT_DIR\n dda inv -- -e dyntest.compute-and-upload-job-index\
\ --bucket-uri $S3_PERMANENT_ARTIFACTS_URI --coverage-folder $E2E_COVERAGE_OUT_DIR\
\ --commit-sha $CI_COMMIT_SHA --job-id $CI_JOB_ID\nfi\n"
- "if [ -d \"$E2E_COVERAGE_OUT_DIR\" ]; then\n DD_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh\
\ $AGENT_API_KEY_ORG2 token) || exit $?; export DD_API_KEY\n for coverage in\
\ \"$E2E_COVERAGE_OUT_DIR\"/*/coverage.txt; do\n datadog-ci coverage upload\
\ --format=go-coverprofile \"$coverage\" || true\n done\nfi\n"
artifacts:
expire_in: 2 weeks
paths:
- $E2E_OUTPUT_DIR
- $E2E_RESULT_JSON
- junit-*.tgz
- $E2E_COVERAGE_OUT_DIR
reports:
annotations:
- $EXTERNAL_LINKS_PATH
when: always
before_script:
- CURRENT_AGENT_ASSERT_VERSION=$(dda inv agent.version) || exit $?; export CURRENT_AGENT_ASSERT_VERSION
- CURRENT_AGENT_ASSERT_PACKAGE_VERSION=$(dda inv agent.version --url-safe)-1 ||
exit $?; export CURRENT_AGENT_ASSERT_PACKAGE_VERSION
- mkdir -p $GOPATH/pkg/mod/cache && zstd -dc modcache_e2e.tar.zst | tar xf - -C
$GOPATH/pkg/mod/cache
- rm -f modcache_e2e.tar.zst
- mkdir -p ~/.pulumi && zstd -dc pulumi_plugins.tar.zst | tar xf - -C ~/.pulumi
- rm -f pulumi_plugins.tar.zst
- "go_bin=\"$(go env GOBIN)\"\nif [ -z \"$go_bin\" ]; then\n go_bin=\"$(go env\
\ GOPATH)/bin\"\nfi\nmkdir -p \"$go_bin\" \"$GOPATH/pkg/mod/cache\"\nzstd -dc\
\ go_tools_bin.tar.zst | tar xf - -C \"$go_bin\"\nzstd -dc modcache_tools.tar.zst\
\ | tar xf - -C \"$GOPATH/pkg/mod/cache\"\n"
- rm -f go_tools_bin.tar.zst modcache_tools.tar.zst
- export PATH=$PATH:$go_bin
- mkdir -p ~/.aws
- "if [ -n \"$E2E_USE_AWS_PROFILE\" ]; then\n echo Using agent-qa-ci aws profile\n\
\ $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E profile >> ~/.aws/config\
\ || exit $?\n # Now all `aws` commands target the agent-qa profile\n export\
\ AWS_PROFILE=agent-qa-ci\nelse\n # Assume role to fetch only once credentials\
\ and avoid rate limits\n echo Assuming ddbuild-agent-ci role\n roleoutput=\"\
$(aws sts assume-role --role-arn arn:aws:iam::669783387624:role/ddbuild-agent-ci\
\ --external-id ddbuild-agent-ci --role-session-name RoleSession)\"\n export\
\ AWS_ACCESS_KEY_ID=\"$(echo \"$roleoutput\" | jq -r '.Credentials.AccessKeyId')\"\
\n export AWS_SECRET_ACCESS_KEY=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SecretAccessKey')\"\
\n export AWS_SESSION_TOKEN=\"$(echo \"$roleoutput\" | jq -r '.Credentials.SessionToken')\"\
\nfi\n"
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AWS_PUBLIC_KEY_PATH
|| exit $?
- touch $E2E_AWS_PRIVATE_KEY_PATH && chmod 600 $E2E_AWS_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
$AGENT_QA_E2E ssh_key_rsa > $E2E_AWS_PRIVATE_KEY_PATH || exit $?
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_AZURE_PUBLIC_KEY_PATH
|| exit $?
- touch $E2E_AZURE_PRIVATE_KEY_PATH && chmod 600 $E2E_AZURE_PRIVATE_KEY_PATH &&
$CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_key_rsa > $E2E_AZURE_PRIVATE_KEY_PATH
|| exit $?
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_QA_E2E ssh_public_key_rsa > $E2E_GCP_PUBLIC_KEY_PATH
|| exit $?
- touch $E2E_GCP_PRIVATE_KEY_PATH && chmod 600 $E2E_GCP_PRIVATE_KEY_PATH && $CI_PROJECT_DIR/tools/ci/fetch_secret.sh
$AGENT_QA_E2E ssh_key_rsa > $E2E_GCP_PRIVATE_KEY_PATH || exit $?
- pulumi login "s3://dd-pulumi-state?region=us-east-1&awssdk=v2&profile=$AWS_PROFILE"
- ARM_CLIENT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE client_id)
|| exit $?; export ARM_CLIENT_ID
- ARM_CLIENT_SECRET=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE token)
|| exit $?; export ARM_CLIENT_SECRET
- ARM_TENANT_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE tenant_id)
|| exit $?; export ARM_TENANT_ID
- ARM_SUBSCRIPTION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_AZURE subscription_id)
|| exit $?; export ARM_SUBSCRIPTION_ID
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_json > ~/gcp-credentials.json
|| exit $?
- export GOOGLE_APPLICATION_CREDENTIALS=~/gcp-credentials.json
- 'gcp_acr_key=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $E2E_GCP credentials_acr_readonly)
|| exit $?
export E2E_GCP_IMAGE_PULL_PASSWORD="b64=$(printf ''%s'' "$gcp_acr_key" | base64
-w 0)"
'
- dda inv -- -e gitlab.generate-ci-visibility-links --output=$EXTERNAL_LINKS_PATH
- export DD_ENV=nativetest
- export DD_CIVISIBILITY_ENABLED=true
- export DD_CIVISIBILITY_AGENTLESS_ENABLED=true
- export DD_CIVISIBILITY_FLAKY_RETRY_ENABLED=false
- export DD_TAGS="gitlab.pipeline_source:${CI_PIPELINE_SOURCE}"
- DD_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_API_KEY_ORG2 token)
|| exit $?; export DD_API_KEY
- export WINDOWS_DDNPM_DRIVER=${WINDOWS_DDNPM_DRIVER:-$(dda inv release.get-release-json-value
"dependencies::WINDOWS_DDNPM_DRIVER" --no-worktree)}
- export WINDOWS_DDPROCMON_DRIVER=${WINDOWS_DDPROCMON_DRIVER:-$(dda inv release.get-release-json-value
"dependencies::WINDOWS_DDPROCMON_DRIVER" --no-worktree)}
image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
needs:
- go_e2e_deps
- artifacts: false
job: go_e2e_test_binaries
- go_tools_deps
- job: new-e2e-base-coverage
optional: true
- deploy_windows_testing-a7
- deploy_installer_oci
- deploy_agent_oci
- qa_installer_script_windows
parallel:
matrix:
- EXTRA_PARAMS: --run "TestEUDMExtensionViaMSI$/TestInstallAndUninstallEUDMExtension$"
- EXTRA_PARAMS: --run "TestEUDMExtensionViaMSI$/TestUpgradeEnablesEUDMExtension$"
- EXTRA_PARAMS: --run "TestEUDMExtensionViaMSI$/TestInstallWithoutEUDMSkipsExtension$"
rules:
- if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
- if: $RUN_E2E_TESTS == "off"
when: never
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- if: $RUN_E2E_TESTS == "on"
when: on_success
- if: $CI_COMMIT_BRANCH == "main"
when: on_success
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
when: on_success
- if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$/
when: on_success
- changes:
compare_to: $COMPARE_TO_BRANCH
paths:
- .gitlab/test/e2e/e2e.yml
- test/e2e-framework/**/*
- test/new-e2e/go.mod
- flakes.yaml
- release.json
- changes:
compare_to: $COMPARE_TO_BRANCH
paths:
- tools/windows/DatadogAgentInstaller/**/*
- .gitlab/windows/test/e2e_install_packages/windows.yml
- test/new-e2e/tests/windows/install-test/**/*
- test/new-e2e/tests/windows/domain-test/**/*
- tasks/msi.py
- omnibus/python-scripts/**/*
- omnibus/lib/**/*
- omnibus/config/projects/agent.rb
- omnibus/config/software/**/*
- omnibus/config/templates/**/*
- release.json
when: on_success
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- allow_failure: true
when: manual
script:
- export IS_DEV_BRANCH="$(dda inv -- -e pipeline.is-dev-branch)"
- DYNAMIC_TESTS_BREAKGLASS=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DYNAMIC_TESTS_BREAKGLASS
value) || exit $?; export DYNAMIC_TESTS_BREAKGLASS
- "if [ \"$DYNAMIC_TESTS_BREAKGLASS\" == \"true\" ] || [ \"$IS_DEV_BRANCH\" == \"\
false\" ] || [ \"$RUN_E2E_TESTS\" == \"on\" ]; then\n export DYNAMIC_TESTS_FLAG=\"\
\"\nfi\n"
- export E2E_IMAGE_PULL_PASSWORD=$(aws ecr get-login-password),$E2E_GCP_IMAGE_PULL_PASSWORD
- dda inv -- -e new-e2e-tests.run $DYNAMIC_TESTS_FLAG $PRE_BUILT_BINARIES_FLAG $MAX_RETRIES_FLAG
--local-package $CI_PROJECT_DIR/$OMNIBUS_BASE_DIR --result-json $E2E_RESULT_JSON
--targets $TARGETS --junit-tar junit-${CI_JOB_ID}.tgz ${EXTRA_PARAMS} --test-washer
--logs-folder=$E2E_OUTPUT_DIR/logs --logs-post-processing --logs-post-processing-test-depth=$E2E_LOGS_PROCESSING_TEST_DEPTH
stage: e2e_install_packages
tags:
- arch:amd64
- specific:true
timeout: 45m
variables:
AGENT_MAJOR_VERSION: 7
DYNAMIC_TESTS_FLAG: --impacted
E2E_AWS_PRIVATE_KEY_PATH: /tmp/agent-qa-aws-ssh-key
E2E_AWS_PUBLIC_KEY_PATH: /tmp/agent-qa-aws-ssh-key.pub
E2E_AZURE_PRIVATE_KEY_PATH: /tmp/agent-qa-azure-ssh-key
E2E_AZURE_PUBLIC_KEY_PATH: /tmp/agent-qa-azure-ssh-key.pub
E2E_COMMIT_SHA: $CI_COMMIT_SHORT_SHA
E2E_COVERAGE_OUT_DIR: $CI_PROJECT_DIR/coverage
E2E_GCP_PRIVATE_KEY_PATH: /tmp/agent-qa-gcp-ssh-key
E2E_GCP_PUBLIC_KEY_PATH: /tmp/agent-qa-gcp-ssh-key.pub
E2E_IMAGE_PULL_REGISTRY: 669783387624.dkr.ecr.us-east-1.amazonaws.com,us-central1-docker.pkg.dev
E2E_IMAGE_PULL_USERNAME: AWS,_json_key
E2E_KEY_PAIR_NAME: datadog-agent-ci-rsa
E2E_LOGS_PROCESSING_TEST_DEPTH: 1
E2E_OUTPUT_DIR: $CI_PROJECT_DIR/e2e-output
E2E_PIPELINE_ID: $CI_PIPELINE_ID
E2E_PREBUILD_S3_URI: $S3_PERMANENT_ARTIFACTS_URI/e2e-pre-build/$CI_PIPELINE_ID
E2E_RESULT_JSON: $CI_PROJECT_DIR/e2e_test_output.json
E2E_SKIP_WINDOWS: $SKIP_WINDOWS
E2E_USE_AWS_PROFILE: 'true'
EXTERNAL_LINKS_PATH: external_links_$CI_JOB_ID.json
EXTRA_PARAMS: --run "TestEUDMExtensionViaMSI"
FLAKY_PATTERNS_CONFIG: $CI_PROJECT_DIR/flaky-patterns-runtime.yaml
GIT_STRATEGY: clone
KUBERNETES_CPU_REQUEST: 6
KUBERNETES_MEMORY_LIMIT: 16Gi
KUBERNETES_MEMORY_REQUEST: 12Gi
MAX_RETRIES_FLAG: ''
PRE_BUILT_BINARIES_FLAG: --use-prebuilt-binaries
REMOTE_STACK_CLEANING: 'true'
SHOULD_RUN_IN_FLAKES_FINDER: 'true'
TARGETS: ./tests/installer/windows
TEAM: windows-productswindows_zip_eudm_x64windows_zip_eudm_x64:
artifacts:
expire_in: 2 weeks
paths:
- omnibus/pkg/pipeline-$CI_PIPELINE_ID
before_script:
- C:\ci-identities-gitlab-job-client.exe assume-role
id_tokens:
BUILDBARN_ID_TOKEN:
aud: buildbarn.us1.ddbuild.io
CI_IDENTITIES_GITLAB_ID_TOKEN:
aud: ci-identities
needs:
- go_deps
rules:
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- when: on_success
script:
- $ErrorActionPreference = "Stop"
- . ./tools/ci/sanitize-goproxy.ps1
- if (Test-Path omnibus\pkg) { remove-item -recurse -force omnibus\pkg }
- mkdir omnibus\pkg
- '.\tools\ci\docker-run-with-bazel-cache.ps1 -m 24576M -v "$(Get-Location):c:\mnt"
-e DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS="${DDA_FEATURE_FLAGS_CI_SSM_KEY_WINDOWS}"
-e GITLAB_CI -e CI_JOB_ID -e CI_PIPELINE_ID -e CI_PROJECT_NAME -e CI_COMMIT_BRANCH
-e CI_JOB_NAME_SLUG -e CI_COMMIT_REF_NAME -e OMNIBUS_TARGET -e WINDOWS_BUILDER=true
-e GOMODCACHE="c:\modcache" -e GOPROXY -e GONOSUMDB -e AWS_NETWORKING=true -e
SIGN_WINDOWS_DD_WCS=true -e WINDOWS_SIGNING_CERT -e WINDOWS_SIGNING_CONFIG -e
TARGET_ARCH="$ARCH" -e BUCKET_BRANCH -e S3_OMNIBUS_CACHE_BUCKET -e S3_OMNIBUS_GIT_CACHE_BUCKET
-e BUNDLE_MIRROR__RUBYGEMS__ORG -e PIP_INDEX_URL -e AGENT_API_KEY_ORG2 -e OMNIBUS_GIT_CACHE_DIR=${Env:TEMP}/${CI_PIPELINE_ID}/omnibus-git-cache
-e AGENT_FLAVOR -e OMNIBUS_RUBY_VERSION -e PYTHONUTF8=1 -e DEPLOY_AGENT -e CI_JOB_TOKEN
-e CI_IDENTITIES_GITLAB_ID_TOKEN ${WINBUILDIMAGE} powershell -C "c:\mnt\tasks\winbuildscripts\Build-OmnibusTarget.ps1
-BuildOutOfSource 1 -InstallDeps 1 -CheckGoVersion 1"
'
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
- get-childitem omnibus\pkg\pipeline-$CI_PIPELINE_ID
- Invoke-Expression "$S3_CP_CMD omnibus\pkg\pipeline-$CI_PIPELINE_ID\version-manifest.json
$S3_SBOM_STORAGE_URI/$CI_JOB_NAME/version-manifest.json"
- If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
stage: package_build
tags:
- windows-v2:2022
variables:
ARCH: x64
AWS_SHARED_CREDENTIALS_FILE: ${CI_PROJECT_DIR}\.aws\credentials-by-job-id\${CI_JOB_ID}
BAZELISK_HOME: $XDG_CACHE_HOME/bazelisk
GIT_STRATEGY: clone
OMNIBUS_TARGET: eudm
WINBUILDIMAGE: registry.ddbuild.io/ci/datadog-agent-buildimages/windows_ltsc2022_${ARCH}${CI_IMAGE_WIN_LTSC2022_X64_SUFFIX}:${CI_IMAGE_WIN_LTSC2022_X64}
XDG_CACHE_HOME: c:/bzlChanges Summary
ℹ️ Diff available in the job log. |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Files inventory check summaryFile checks results against ancestor 88595771: Results for datadog-agent_7.82.0~rc.3.git.5.bbb0da0.pipeline.125090840-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 8859577 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +0.38 | [-0.59, +1.35] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_no_fs_load | memory utilization | +0.36 | [+0.27, +0.46] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | +0.14 | [+0.10, +0.19] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.02 | [-0.06, +0.02] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_mean_fs_load | memory utilization | -0.06 | [-0.09, -0.02] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_idle | memory utilization | -0.12 | [-0.18, -0.06] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.13 | [-0.38, +0.12] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 148.06MiB ≤ 154MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 731.99KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 482.10MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.13MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 182.65MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 263.85MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 356.39 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 406.77MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
| ✅ | quality_gate_security_idle | cpu_usage | 10/10 | 30.37 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_security_idle | memory_usage | 10/10 | 297.99MiB ≤ 330MiB | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | cpu_usage | 10/10 | 64.01 ≤ 80 | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | memory_usage | 10/10 | 278.45MiB ≤ 310MiB | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | cpu_usage | 10/10 | 23.21 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | memory_usage | 10/10 | 284.28MiB ≤ 320MiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Profiling Replicate Execution Failures (ddprof)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_logs | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_security_mean_fs_load | comparison | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_no_fs_load | baseline | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_no_fs_load | comparison | 10 | Crashed (exit code: 134) | Debug Dashboard |
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 514a2e1 from #53406.
What does this PR do?
Migrates the Windows AI Usage Chrome Native Messaging host + desktop monitor out of the MSI and into a new
eudmfleet installer extension (modeled onddot), installed only when End User Device Monitoring (EUDM) is enabled. This is the long-term follow-up to the interim MSI-level EUDM gate (#53289).Gating (
installAgentExtensions): appends theeudmextension on Windows when EUDM is signaled viaDD_INFRASTRUCTURE_MODE=end_user_deviceorinfrastructure_mode: end_user_devicealready indatadog.yaml(covers upgrades that don't re-pass the env var). The extension is pulled from thedatadog-agentOCI image'sai-usagelayer by the post-install hook (RunPostInstallHook→installAgentExtensions), which already runs on every MSI install/upgrade.New extension hooks (
datadog_agent_eudm_windows.go) reproduce what the MSI custom actions used to do:bin\agent(user-executable via Program Files ACL inheritance),chrome_extension_id, fallback) + the two HKLMNativeMessagingHostsregistry entries,Datadog AI Usage Agentscheduled task (schtasks, UTF‑16LE XML).preRemovetears all of it down.MSI strip + migration cleanup:
File, both Chrome regkeys, theWriteConfigyaml/manifest generation, and theConfigureAiUsageMonitorDesktopMonitorcustom action.DD_INFRASTRUCTURE_MODEintoRunPostInstallHook.Packaging: new
//cmd/ai_prompt_logger:install-extensionBazel target (flat layer layout), removed the omnibus MSI-payload staging, and addedmsi.fetch-artifacts --ai-usage/msi.package-oci --eudm(--extension ai-usage=).Motivation
https://datadoghq.atlassian.net/browse/WINA-2867 — AI Usage monitoring should be gated behind EUDM rather than installed unconditionally. The ticket calls for this to become a fleet package (this PR), superseding the interim MSI gate.
Describe how you validated your changes
Additional Notes
if a machine has old MSI-created AI Usage artifacts but does not install the ai-usage extension, extension hooks never run, so those old artifacts would not be cleaned by this
removal.