Skip to content

Various fixes in config initialization and schema codegen#53765

Open
dustmop wants to merge 7 commits into
mainfrom
dustin.long/various-config-init-fix
Open

Various fixes in config initialization and schema codegen#53765
dustmop wants to merge 7 commits into
mainfrom
dustin.long/various-config-init-fix

Conversation

@dustmop

@dustmop dustmop commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix various bugs in the schema codegen and the config initialization:

  • Assign linux-only sockets in the fixup step instead of using GetPlatformDefault
  • Fix the default value of network_config.dns_monitoring_port to be a []int instead of []float64
  • Add a message to the generated code to state that is generated
  • Fix the regex for bindDelegatedAuth so that it works with the empty string
  • Output settings for PAR in a dedicated function

Motivation

Codegen for config initialization will enable the schema as the source of truth

Describe how you validated your changes

Run dda inv schema.codegen and diff the result against the source files in tree

Additional Notes

@dustmop dustmop requested review from a team as code owners July 16, 2026 20:00
@dustmop dustmop requested a review from s-alad July 16, 2026 20:00
@dustmop dustmop added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Jul 16, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jul 16, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Jul 16, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6a33885fc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// This product includes software developed at Datadog (https://www.datadoghq.com/).
// Copyright 2016-present Datadog, Inc.

// NOTE! This is a generated file, do not modify it. Created by `dda inv schema.codegen`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update generated settings files for the new header

When schema.codegen --keep-orig-order --check runs, this header is prepended to every generated *_settings.go file, but none of the generated setup files in this commit received it (for example, pkg/config/setup/apm_settings.go still starts directly with package setup). The codegen consistency check will therefore diff every generated file and fail; regenerate and commit those files alongside this generator change.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the files aren't generated yet, which is why schema.codegen --check isn't enforced at the moment.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 51.88% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ee5a9f8 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 90665edb:

Results for datadog-agent_7.83.0~devel.git.177.ee5a9f8.pipeline.125170882-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 90665ed
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -32.0 KiB (0.00% reduction, +0.37% of buffer) 749.845 → 749.814 → 758.200
agent_deb_amd64_fips -8.0 KiB (0.00% reduction, +0.15% of buffer) 704.742 → 704.735 → 709.840
agent_heroku_amd64 -4.0 KiB (0.00% reduction, +0.05% of buffer) 307.709 → 307.705 → 315.230
agent_msi -20.0 KiB (0.00% reduction, +0.15% of buffer) 643.677 → 643.657 → 656.640
agent_rpm_amd64 -32.0 KiB (0.00% reduction, +0.37% of buffer) 749.829 → 749.798 → 758.170
agent_rpm_amd64_fips -8.0 KiB (0.00% reduction, +0.15% of buffer) 704.726 → 704.718 → 709.840
agent_rpm_arm64 -4.0 KiB (0.00% reduction, +0.12% of buffer) 726.443 → 726.439 → 729.660
agent_rpm_arm64_fips -4.0 KiB (0.00% reduction, +0.10% of buffer) 685.041 → 685.037 → 688.860
agent_suse_amd64 -32.0 KiB (0.00% reduction, +0.37% of buffer) 749.829 → 749.798 → 758.170
agent_suse_amd64_fips -8.0 KiB (0.00% reduction, +0.15% of buffer) 704.726 → 704.718 → 709.840
agent_suse_arm64 -4.0 KiB (0.00% reduction, +0.12% of buffer) 726.443 → 726.439 → 729.660
agent_suse_arm64_fips -4.0 KiB (0.00% reduction, +0.10% of buffer) 685.041 → 685.037 → 688.860
docker_agent_amd64 -28.0 KiB (0.00% reduction, +0.52% of buffer) 808.548 → 808.521 → 813.790
docker_agent_arm64 -4.0 KiB (0.00% reduction, +0.08% of buffer) 810.171 → 810.167 → 815.030
docker_agent_jmx_amd64 -28.0 KiB (0.00% reduction, +0.54% of buffer) 999.445 → 999.418 → 1004.550
docker_agent_jmx_arm64 -4.0 KiB (0.00% reduction, +0.08% of buffer) 989.721 → 989.717 → 994.710
docker_dogstatsd_amd64 -4.0 KiB (0.01% reduction, +0.56% of buffer) 39.216 → 39.212 → 39.910
docker_host_profiler_amd64 -4.4 KiB (0.00% reduction, +0.03% of buffer) 303.101 → 303.097 → 317.640
dogstatsd_deb_amd64 -4.0 KiB (0.01% reduction, +0.33% of buffer) 29.955 → 29.951 → 31.150
dogstatsd_rpm_amd64 -4.0 KiB (0.01% reduction, +0.33% of buffer) 29.955 → 29.951 → 31.150
dogstatsd_suse_amd64 -4.0 KiB (0.01% reduction, +0.33% of buffer) 29.955 → 29.951 → 31.150
iot_agent_deb_amd64 -4.0 KiB (0.01% reduction, +2.10% of buffer) 46.194 → 46.190 → 46.380
iot_agent_rpm_amd64 -4.0 KiB (0.01% reduction, +2.11% of buffer) 46.195 → 46.191 → 46.380
iot_agent_suse_amd64 -4.0 KiB (0.01% reduction, +2.10% of buffer) 46.194 → 46.190 → 46.380
9 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
docker_cluster_agent_amd64 209.885 MiB
docker_cluster_agent_arm64 222.952 MiB
docker_cws_instrumentation_amd64 7.447 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_arm64 37.367 MiB
docker_host_profiler_arm64 314.591 MiB
dogstatsd_deb_arm64 27.994 MiB
iot_agent_deb_arm64 42.882 MiB
iot_agent_deb_armhf 43.647 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b94239c6-862b-4172-bf3b-ecff45158d60

Baseline: 90665ed
Comparison: a020191
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.94 [-0.06, +1.94] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.44 [+0.40, +0.47] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.38 [+0.30, +0.45] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.06 [-0.04, +0.16] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.02 [-0.04, +0.08] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.61 [-0.66, -0.56] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.40 [-1.64, -1.15] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 146.49MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 732.76KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 493.84MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 185.31MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.12MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 365.72 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 401.13MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 27.50 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 297.91MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.66 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 279.68MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 26.28 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 283.19MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_idle comparison 10 Oom killed Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent team/agent-configuration team/fleet-automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant