Move installer embedded templates to stop gazelle warnings.

[aiuto]

What does this PR do?

Fixes a bazel run //:gazelle warning for pkg/fleet/installer/packages/embedded:

gazelle: .../embed.go:29:2: pattern gen/oci/*.service: matched no files

Motivation

Gazelle's embed resolver won't walk into directories excluded via # gazelle:exclude. The root BUILD.bazel excludes pkg/fleet/installer/packages/embedded/tmpl, which previously also housed the generated tmpl/gen/ output — so gazelle couldn't see those files even though they exist and were correctly wired via manual # keep embedsrcs.

This moves the generated templates output directory from tmpl/gen/ to a sibling gen/ directory outside the excluded tmpl/ subtree, so gazelle can resolve the embed patterns and manage embedsrcs itself. Same pattern previously applied to pkg/security/probe/constantfetch.

Describe how you validated your changes

• bazel run //:gazelle -- pkg/fleet/installer/packages/embedded — no warnings, no unexpected diffs
• bazel build //pkg/fleet/installer/packages/embedded:embedded :tmpl_lib :tmpl
• bazel test //pkg/fleet/installer/packages/embedded:tmpl_test — passes

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dee72c0a64

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[datadog-datadog-prod-us1-2]

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 51.99% (+0.13%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 331071c | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor ccd03be2:

Results for datadog-agent_7.83.0~devel.git.176.331071c.pipeline.125150594-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ccd03be
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	750.057 MiB
✅	agent_deb_amd64_fips	704.966 MiB
✅	agent_heroku_amd64	307.921 MiB
✅	agent_msi	643.918 MiB
✅	agent_rpm_amd64	750.041 MiB
✅	agent_rpm_amd64_fips	704.950 MiB
✅	agent_rpm_arm64	726.644 MiB
✅	agent_rpm_arm64_fips	685.238 MiB
✅	agent_suse_amd64	750.041 MiB
✅	agent_suse_amd64_fips	704.950 MiB
✅	agent_suse_arm64	726.644 MiB
✅	agent_suse_arm64_fips	685.238 MiB
✅	docker_agent_amd64	808.760 MiB
✅	docker_agent_arm64	810.371 MiB
✅	docker_agent_jmx_amd64	999.658 MiB
✅	docker_agent_jmx_arm64	989.921 MiB
✅	docker_cluster_agent_amd64	209.791 MiB
✅	docker_cluster_agent_arm64	222.889 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.223 MiB
✅	docker_dogstatsd_arm64	37.367 MiB
✅	docker_host_profiler_amd64	303.101 MiB
✅	docker_host_profiler_arm64	314.592 MiB
✅	dogstatsd_deb_amd64	29.960 MiB
✅	dogstatsd_deb_arm64	28.003 MiB
✅	dogstatsd_rpm_amd64	29.960 MiB
✅	dogstatsd_suse_amd64	29.960 MiB
✅	iot_agent_deb_amd64	46.109 MiB
✅	iot_agent_deb_arm64	42.805 MiB
✅	iot_agent_deb_armhf	43.573 MiB
✅	iot_agent_rpm_amd64	46.110 MiB
✅	iot_agent_suse_amd64	46.109 MiB

[aiuto]

fixed in 5fefc16. go:embed resolves relative to the source file's directory (tmpl/), not the BUILD package's; Bazel's embedsrcs masked the mismatch. Switched main_test.go to read gen/ from disk instead of embedding it, and verified against go vet, dda inv test, and bazel test this time.

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c43b0c7c-5e73-4ac7-99e9-a3458697364d

Baseline: ccd03be
Comparison: dee72c0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.63	[-0.35, +1.61]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.29	[+0.19, +0.38]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.17	[+0.11, +0.23]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.01	[-0.08, +0.05]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.17	[-0.22, -0.12]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.26	[-0.51, -0.01]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.70	[-0.74, -0.67]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	146.61MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	736.68KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	490.72MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	180.95MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.79MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	360.56 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	400.37MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	29.57 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	295.38MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	74.51 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	276.19MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	24.36 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	285.82MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Oom killed	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.