Skip to content

[SVLS-6465] Make needed modifications to sandbox deploy to apply values to template.yml#190

Open
TophrC-dd wants to merge 7 commits into
DataDog:mainfrom
TophrC-dd:release-script-fix
Open

[SVLS-6465] Make needed modifications to sandbox deploy to apply values to template.yml#190
TophrC-dd wants to merge 7 commits into
DataDog:mainfrom
TophrC-dd:release-script-fix

Conversation

@TophrC-dd
Copy link
Copy Markdown
Contributor

@TophrC-dd TophrC-dd commented Mar 27, 2025

What does this PR do?

This pr makes changes to the deployment script so variables are modified during a sandbox deploy. the template file will just work out of the box.

Motivation

Not being able to use the template after a sandbox deploy was kind of a drag.

Testing Guidelines

Since no gitlab access I tested the change locally.

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@TophrC-dd TophrC-dd requested a review from a team as a code owner March 27, 2025 19:58
@hannahqjiang
Copy link
Copy Markdown
Contributor

hannahqjiang commented Mar 27, 2025

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 27, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-27 20:03:32 UTC ℹ️ Start processing command /merge

2025-03-27 20:03:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-03-27 20:33:37 UTC ⚠️ MergeQueue: This merge request was unqueued

hannah.jiang@datadoghq.com unqueued this merge request

@hannahqjiang
Copy link
Copy Markdown
Contributor

hannahqjiang commented Mar 27, 2025

/remove

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Mar 27, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-27 20:33:32 UTC ℹ️ Start processing command /remove

2025-03-27 20:33:35 UTC ℹ️ Devflow: /remove

@TophrC-dd
Copy link
Copy Markdown
Contributor Author

TophrC-dd commented Apr 29, 2025

/merge

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Apr 29, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-29 14:41:21 UTC ℹ️ Start processing command /merge

2025-04-29 14:42:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-29 18:42:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@TalUsvyatsky TalUsvyatsky requested review from a team and hannahqjiang and removed request for hannahqjiang August 13, 2025 13:25
@TalUsvyatsky
Copy link
Copy Markdown
Contributor

TalUsvyatsky commented Aug 13, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Aug 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-13 13:34:19 UTC ℹ️ Start processing command /merge

2025-08-13 13:34:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-13 13:36:08 UTC ⚠️ MergeQueue: This merge request was unqueued

tal.usvyatsky@datadoghq.com unqueued this merge request

@TalUsvyatsky TalUsvyatsky removed the request for review from clifordshelton August 13, 2025 13:35
@TalUsvyatsky
Copy link
Copy Markdown
Contributor

TalUsvyatsky commented Aug 13, 2025

/remove

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex Bot commented Aug 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-08-13 13:36:00 UTC ℹ️ Start processing command /remove

2025-08-13 13:36:06 UTC ℹ️ Devflow: /remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TalUsvyatsky TalUsvyatsky TalUsvyatsky approved these changes

+1 more reviewer

@hannahqjiang hannahqjiang hannahqjiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TophrC-dd @hannahqjiang @TalUsvyatsky