docs(php-sample-app): clarify build.sh is always required#263
Closed
Kyle-Neale wants to merge 1 commit into
Closed
docs(php-sample-app): clarify build.sh is always required#263Kyle-Neale wants to merge 1 commit into
Kyle-Neale wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #257, which fixes the underlying vendor-path mismatch rather than documenting it as a permanent constraint. Pinned composer's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample app's README currently frames
./build.shas needed "so the app can be staged on offline Cloud Foundry environments" — implying it's optional online. In practice it's always required, becausephp_buildpack's owncomposer installwrites tolib/vendor/, buthtdocs/index.phploads../vendor/autoload.php(i.e../vendor/). Withoutbuild.shthe app boots withPHP Fatal error: Failed opening required '/home/vcap/app/htdocs/../vendor/autoload.php'.This PR tightens the wording to state the autoload requirement up front and keeps the offline-staging note as a secondary benefit.
Surfaced while verifying #257 on TAS 10.4 (bark-12516): an initial push without
build.shreturned HTTP 500 for that exact reason.