chore(php): use boolean env vars in sample manifest#272
Open
trevdem wants to merge 2 commits into
Open
Conversation
Align the PHP sample app with Node.js and Java examples that use bare `true` instead of a quoted string. Co-authored-by: Cursor <cursoragent@cursor.com>
Use bare true for DD_APM_INSTRUMENTATION_ENABLED and DD_ENABLE_CAPI_METADATA_COLLECTION to match DD_LOGS_ENABLED and DD_PROFILING_ENABLED in the same file. Co-authored-by: Cursor <cursoragent@cursor.com>
trevdem
changed the title
Author
|
@DataDog/agent-integrations Could someone from the team take a look when you have a chance? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
truefor all boolean env vars in the PHP sample app manifest:DD_PROFILING_ENABLEDDD_APM_INSTRUMENTATION_ENABLEDDD_ENABLE_CAPI_METADATA_COLLECTIONDD_LOGS_ENABLED(already baretrue) and with the Node.js/Java sample appsTest plan
run-datadog.shchecks[ "${DD_PROFILING_ENABLED:-}" = "true" ], which matches YAML booleantruewhen rendered as an env varDD_APM_INSTRUMENTATION_ENABLEDandDD_ENABLE_CAPI_METADATA_COLLECTIONuse the same string comparison pattern elsewhere in the buildpack