fix(traces): downgrade handle_proxy body-read failure from ERROR to WARN#1045
Closed
litianningdatadog wants to merge 2 commits intomainfrom
Closed
fix(traces): downgrade handle_proxy body-read failure from ERROR to WARN#1045litianningdatadog wants to merge 2 commits intomainfrom
litianningdatadog wants to merge 2 commits intomainfrom
Conversation
…n logger Commit 3b533a0 introduced serde_json::json!() for JSON log formatting, which allocates a heap Map+Value on every log call and pulled in the tracing-serde crate via the "json" feature of tracing-subscriber, increasing binary size and Lambda init duration. Replace with direct write!/writeln! calls to the tracing Writer plus a small write_json_escaped helper that handles all 6 mandatory JSON escape sequences inline. The output format is identical. Also remove the "json" feature from tracing-subscriber, dropping tracing-serde as a transitive dependency. JIRA: https://datadoghq.atlassian.net/browse/SVLS-8619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://datadoghq.atlassian.net/browse/SLES-2729
Issue: #1000
Overview
When AWS Lambda freezes or terminates a function instance, the OS immediately closes all TCP sockets. The extension's proxy HTTP handler (
handle_proxy) was mid-read on the request body — this read fails witherror reading a body from connectionand was logged atERRORlevel, generating noise with no actionable signal.This is expected Lambda lifecycle behaviour: the Lambda function completed successfully and nothing in the extension is broken. The
ERRORlevel implies an extension fault, which misleads operators.Change: Introduce a
warn_responsehelper (mirroring the existingerror_response/success_responsetrio) and use it for body-read failures inhandle_proxy. The log message content is unchanged — only the severity is downgraded fromERRORtoWARN.Testing