feat: [SVLS-6242] bottlecap fips builds#644
Merged
apiarian-datadog merged 12 commits intomainfrom May 6, 2025
Merged
Conversation
Contributor
Author
|
This does not yet work for alpine, unfortunately. We're seeing errors similar to aws/aws-lc-rs#762 so maybe this is not just us. |
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
from
e6f60f4 to
d6522d9
Compare
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
8 times, most recently
from
aeca829 to
1e97cd9
Compare
This was referenced Apr 16, 2025
|
|
||
| [features] | ||
| default = ["reqwest/rustls-tls", "dogstatsd/default"] | ||
| fips = [ |
Contributor
Author
There was a problem hiding this comment.
unfortunately, as written, the default feature is incompatible with the fips feature. so in order to build the fips feature correctly we have to disable the default feature. this is fine for normal builds where we don't care about fips, but it means that when building or checking the fips feature we have to remember to say --no-default-features in addition to --features=fips. our build scripts take care of this, but maybe there's a better way to do this?
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
4 times, most recently
from
f1b2982 to
5496e2b
Compare
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
from
25a6976 to
eea5a5b
Compare
duncanista
reviewed
Apr 18, 2025
duncanista
reviewed
Apr 18, 2025
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
2 times, most recently
from
f6c439d to
a37ca6e
Compare
apiarian-datadog
changed the title
duncanista
reviewed
Apr 25, 2025
duncanista
reviewed
Apr 25, 2025
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
5 times, most recently
from
73c8b7e to
323f346
Compare
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
from
37637a1 to
ebad2a7
Compare
duncanista
reviewed
Apr 30, 2025
duncanista
reviewed
Apr 30, 2025
duncanista
approved these changes
Apr 30, 2025
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
LGTM – left a couple nits, but overall amazing job with this
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
from
16f91e8 to
d561651
Compare
duncanista
reviewed
May 5, 2025
duncanista
reviewed
May 5, 2025
…le for reqwest::Client::builder
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6242-bottlecap-fips
branch
from
d561651 to
57a6119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building bottlecap with fips mode.
This is entirely focused on removing
ring(and other non-FIPS-compliant dependencies from ourfips-featured builds.)