Ddtrace now requires patch.py rather than __init__.py files.#566
Merged
purple4reina merged 1 commit intomainfrom Feb 28, 2025
Merged
Ddtrace now requires patch.py rather than __init__.py files.#566purple4reina merged 1 commit intomainfrom
purple4reina merged 1 commit intomainfrom
Conversation
joeyzhao2018
approved these changes
Feb 28, 2025
Contributor
joeyzhao2018
left a comment
There was a problem hiding this comment.
This fix LGTM.
However... i wonder how it was working before?
avedmala
pushed a commit
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of keeping
__init__.pyfiles, keeppatch.pyfiles when building for layer releases.Motivation
This change in dd-trace-py https://github.com/DataDog/dd-trace-py/pull/12153/files#diff-6a70144455f9fea41df44b3e578cfaa81ae9c5297e41cce9ef02a5b719013817R265 now means ddtrace looks for
patch.pyfiles. This change is backported to both the v2 and v3 release lines.Testing Guidelines
The integration tests should cover this.
Additional Notes
Types of Changes
Check all that apply