Merged
Conversation
nhulston
force-pushed
the
nicholas.hulston/submit-metric-for-dynamodb-stream-type
branch
from
f8d1674 to
326a1c8
Compare
nhulston
force-pushed
the
nicholas.hulston/submit-metric-for-dynamodb-stream-type
branch
from
326a1c8 to
309ebb5
Compare
duncanista
approved these changes
Mar 19, 2025
nhulston
deleted the
nicholas.hulston/submit-metric-for-dynamodb-stream-type
branch
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| return _calculate_s3_span_pointers_for_event(event) | ||
|
|
||
| elif event_source.equals(EventTypes.DYNAMODB): | ||
| # Temporary metric. TODO eventually remove(@nhulston) |
Contributor
There was a problem hiding this comment.
⚪ Code Quality Violation
Suggested change
| # Temporary metric. TODO eventually remove(@nhulston) | |
| # Temporary metric. TODO(<owner>) eventually remove(@nhulston) |
comments must have ownership (...read more)
When using TODO or FIXME, specify who write the annotation. It's a best practice to remind you who created the annotation and have potential context and information about this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Submits a metric for DynamoDB stream type, that we can later query on metabase.
The type of stream will be identified via a tag on the metric:
streamtype:new_and_old_imagesstreamtype:new_imagestreamtype:old_imagestreamtype:keys_onlyMotivation
Get insights on what stream setting customers are using to come up with a decision regarding: https://docs.google.com/document/d/1phVoU-XtzxjVmECNz3JOC6SJv5GtGj4lbjwXyCv-VUs/edit?tab=t.0#heading=h.ety0x21ybvdr
Testing Guidelines
Manual
and integration tests
Additional Notes
PRs to allow us to query on metabase:
https://github.com/DataDog/consul-config/pull/292757
https://github.com/DataDog/consul-config/pull/292758
Types of Changes
Check all that apply