Conversation
duncanista
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
__future__import.Motivation
It is not needed anymore.
Testing Guidelines
I ran a before/after comparison. We see there's actually a very very slight cold start gain when removing the import.
Additional Notes
The
__future__imports allow you to optionally apply a new python feature which will be required in a future python version.Looking at this chart https://docs.python.org/3/library/__future__.html#module-contents, we see that the
absolute_importfeature was added to python in v3.0. We can therefore remove this import because the feature is on by default anyway.Types of Changes
Check all that apply