feat: disable direct metric submission in govcloud#582
Closed
apiarian-datadog wants to merge 2 commits intomainfrom
Closed
feat: disable direct metric submission in govcloud#582apiarian-datadog wants to merge 2 commits intomainfrom
apiarian-datadog wants to merge 2 commits intomainfrom
Conversation
1aa4ecb to
7f4cd7a
Compare
Contributor
Author
|
putting this on hold for now while we get bottlecap to be fips-compliant. |
Contributor
Author
|
closing in favor of #588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skips metric submission when we're running in govcloud.
Motivation
We cannot easily guarantee FIPS-compliance of the associated api calls. Let's disable them for now.
Testing Guidelines
Unit tests, and checking with our self-monitoring stacks.
Types of Changes
Check all that apply