[MLOB] revert forced agentless and api key fetching#585
Merged
Conversation
| agentless_enabled=True, | ||
| api_key=llmobs_api_key, | ||
| ) | ||
| LLMObs.enable() |
Contributor
There was a problem hiding this comment.
Would it be worth it to consolidate these two if llmobs_env_var blocks into a single location?
Collaborator
Author
There was a problem hiding this comment.
i think we need to have them separate because we use LLMObs in two different scopes. if we imported and enabled in the same block, then we wouldn't be able to use it in the flush block without importing it again. i think it's OK to leave as-is for now
Contributor
There was a problem hiding this comment.
ahhh, great point! you're totally right.
purple4reina
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reverts forced
agentless_enabled=Trueandapi_keyfetching as part of the LLMObs init process for the lambda.Motivation
We recently made a change to add our endpoints to the extension and add a lambda instrument command to use the latest layer versions and set
DD_LLMOBS_ENABLED=trueDD_LLMOBS_AGENTLESS_ENABLED=falseto specifically use the agent in the extensionDD_LLMOBS_ML_APPto whatever was passed into the--llmobscommandBy using the agent in the extension, we can take advantage of the API secret key parsing there, and reduce the overhead here for importing anything
boto3-related. Additionally, it's now a more seamless experience overall.Testing Guidelines
Verified with a build of the layer with the already-released extension layer.
Additional Notes
Types of Changes
Check all that apply