Add DatadogCSIDriver controller by tbavelier · Pull Request #2844 · DataDog/datadog-operator

tbavelier · 2026-04-01T09:25:27Z

What does this PR do?

Adds DatadogCSIDriver CRD and controller

Motivation

Supporting CSI driver management with operator

Additional Notes

This is best reviewed commit by commit:

e0d1d62: CRD types and generated files
3295be9: outercontroller and RBAC
e4573fa: inner reconciler
d0adb80: plumbing into startup
8bcd714: tests
327fdc8: simplify update logic

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

Agent: vX.Y.Z
Cluster Agent: vX.Y.Z

Describe your test plan

TBD

Checklist

PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
PR has a milestone or the qa/skip-qa label
All commits are signed (see: signing commits)

Define the DatadogCSIDriver, DatadogCSIDriverSpec, DatadogCSIDriverOverride, and DatadogCSIDriverStatus types in api/datadoghq/v1alpha1. The CRD enables declarative management of the Datadog CSI Driver via the operator, replacing the standalone Helm chart deployment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Controller-runtime wiring for the DatadogCSIDriver reconciler. Watches the primary CR with GenerationChangedPredicate, owned DaemonSets for all changes (including status), and CSIDriver objects via label-based enqueue for drift detection on the cluster-scoped resource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Implements the reconciliation logic for the DatadogCSIDriver controller: - Deferred SSA status patch with ObservedGeneration tracking - CSIDriver object management with label-based ownership (part-of pattern) - DaemonSet management with drift detection via generation tracking - Override system with merge-by-name semantics (env vars, volumes, mounts) - Image resolution via pkg/images (supports tag-only overrides) - Finalizer-based cleanup of the cluster-scoped CSIDriver on deletion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Register the controller in setup.go with a feature flag and add the -datadogCSIDriverEnabled flag (default: false) to cmd/main.go. Also registers the storagev1 scheme required for CSIDriver object management. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

codecov-commenter · 2026-04-01T09:36:19Z

Codecov Report

❌ Patch coverage is 66.03053% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.74%. Comparing base (ed2b4df) to head (4ebe5ef).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/controller/datadogcsidriver/daemonset.go	70.42%	87 Missing and 10 partials ⚠️
internal/controller/datadogcsidriver/controller.go	62.50%	38 Missing and 16 partials ⚠️
internal/controller/datadogcsidriver_controller.go	0.00%	19 Missing ⚠️
internal/controller/setup.go	40.00%	6 Missing ⚠️
cmd/main.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
+ Coverage   39.24%   39.74%   +0.50%     
==========================================
  Files         314      318       +4     
  Lines       27288    27812     +524     
==========================================
+ Hits        10708    11054     +346     
- Misses      15792    15944     +152     
- Partials      788      814      +26

Flag	Coverage Δ
unittests	`39.74% <66.03%> (+0.50%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/controller/datadogcsidriver/csidriver.go	`100.00% <100.00%> (ø)`
cmd/main.go	`6.66% <33.33%> (+0.23%)`	⬆️
internal/controller/setup.go	`36.12% <40.00%> (+0.21%)`	⬆️
internal/controller/datadogcsidriver_controller.go	`0.00% <0.00%> (ø)`
internal/controller/datadogcsidriver/controller.go	`62.50% <62.50%> (ø)`
internal/controller/datadogcsidriver/daemonset.go	`70.42% <70.42%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2b4df...4ebe5ef. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87ed63e94c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-02T08:59:58Z

+	if current.Labels == nil ||
+		current.Labels[kubernetes.AppKubernetesManageByLabelKey] != "datadog-operator" ||
+		current.Labels[kubernetes.AppKubernetesPartOfLabelKey] != expectedPartOf {
+		logger.Info("Updating CSIDriver ownership labels", "csidriver", driverName)


Reconcile CSIDriver spec drift on existing objects

When a CSIDriver already exists, this branch only checks ownership labels and returns without reconciling current.Spec against buildCSIDriverObject(instance).Spec. That means out-of-band edits to fields like attachRequired, podInfoOnMount, or lifecycle modes will persist indefinitely, even though the controller watches CSIDriver events for drift. The result is that the operator can report success while leaving an unintended CSI API configuration in place.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-02T08:59:58Z

+		return ctrl.Result{}, nil
+	}
+
+	driverName := getCSIDriverName(instance)


Track previous CSIDriver name for finalizer cleanup

Finalizer cleanup always deletes only getCSIDriverName(instance), i.e. the current spec value. If .spec.csiDriverName is changed from one name to another, reconcile can create/manage the new object but the previously managed cluster-scoped CSIDriver is never removed; deleting the CR later cleans up only the latest name and leaves the old one orphaned.

Useful? React with 👍 / 👎.

adel121 · 2026-04-02T11:40:34Z

+
+	// SecurityContext holds pod-level security attributes.
+	// +optional
+	SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"`


In the csi driver helm chart we don't define a pod-level security context.

We expose a container-level security contexts:

Here for the registrar

Here for the node server

In the CRD we expose pod level security context only, is this intentional?

Nevermind, I have just noticed we also have pod level security context in helm here.

And in the operator we can override container-level security context via the container overrides.

tbavelier · 2026-04-02T12:07:34Z

Replaced with #2856

tbavelier and others added 5 commits April 1, 2026 11:16

Merge branch 'main' into tbavelier/revert-nightly

600695b

tbavelier added this to the v1.26.0 milestone Apr 1, 2026

tbavelier added the enhancement New feature or request label Apr 1, 2026

github-actions bot added team/container-platform team/container-autoscaling labels Apr 1, 2026

tbavelier added 2 commits April 2, 2026 10:49

Add controller tests

8bcd714

Merge branch 'main' into tbavelier/csi-driver-standalone

87ed63e

tbavelier marked this pull request as ready for review April 2, 2026 08:53

tbavelier requested a review from a team April 2, 2026 08:53

tbavelier requested a review from a team as a code owner April 2, 2026 08:53

chatgpt-codex-connector bot reviewed Apr 2, 2026

View reviewed changes

Simplify update logic

327fdc8

tbavelier marked this pull request as draft April 2, 2026 10:19

adel121 reviewed Apr 2, 2026

View reviewed changes

Remove csiDriverName from types and minor changes

4ebe5ef

tbavelier closed this Apr 2, 2026

tbavelier deleted the tbavelier/csi-driver-standalone branch April 8, 2026 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DatadogCSIDriver controller#2844

Add DatadogCSIDriver controller#2844
tbavelier wants to merge 9 commits intomainfrom
tbavelier/csi-driver-standalone

tbavelier commented Apr 1, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Apr 1, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Apr 2, 2026

Uh oh!

chatgpt-codex-connector bot Apr 2, 2026

Uh oh!

adel121 Apr 2, 2026

Uh oh!

adel121 Apr 2, 2026

Uh oh!

tbavelier commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tbavelier commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Minimum Agent Versions

Describe your test plan

Checklist

Uh oh!

codecov-commenter commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

adel121 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

adel121 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

tbavelier commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tbavelier commented Apr 1, 2026 •

edited

Loading

codecov-commenter commented Apr 1, 2026 •

edited

Loading