Skip to content

Add experiment signals to fleet remote config#2872

Open
khewonc wants to merge 15 commits intomainfrom
khewonc/experiment-signals
Open

Add experiment signals to fleet remote config#2872
khewonc wants to merge 15 commits intomainfrom
khewonc/experiment-signals

Conversation

@khewonc
Copy link
Copy Markdown
Collaborator

@khewonc khewonc commented Apr 7, 2026

What does this PR do?

Adds experiment signals: start, stop, and promote. This depends on #2838. The latest commit contains the relevant changes

Motivation

https://datadoghq.atlassian.net/browse/CONTP-1424
https://datadoghq.atlassian.net/browse/CONTP-1425
https://datadoghq.atlassian.net/browse/CONTP-1426

Additional Notes

Merge after #2838

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

TBD

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@khewonc khewonc added this to the v1.26.0 milestone Apr 7, 2026
@khewonc khewonc added the enhancement New feature or request label Apr 7, 2026
@khewonc khewonc requested a review from a team April 7, 2026 13:31
@khewonc khewonc requested review from a team as code owners April 7, 2026 13:31
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e153f00f4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/controller/datadogagent/experiment.go
Comment thread internal/controller/datadogagent/controller_reconcile_v2.go
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 74.46237% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.50%. Comparing base (a646370) to head (eb7b351).

Files with missing lines Patch % Lines
pkg/fleet/daemon.go 69.70% 58 Missing and 15 partials ⚠️
internal/controller/datadogagent/revision.go 79.41% 4 Missing and 3 partials ⚠️
internal/controller/datadogagent/experiment.go 86.11% 3 Missing and 2 partials ⚠️
pkg/remoteconfig/updater.go 0.00% 4 Missing ⚠️
cmd/main.go 0.00% 3 Missing ⚠️
pkg/fleet/experiment.go 93.18% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
+ Coverage   40.03%   40.50%   +0.47%     
==========================================
  Files         319      320       +1     
  Lines       28066    28378     +312     
==========================================
+ Hits        11235    11495     +260     
- Misses      16008    16041      +33     
- Partials      823      842      +19     
Flag Coverage Δ
unittests 40.50% <74.46%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/fleet/remote_config.go 100.00% <100.00%> (ø)
cmd/main.go 6.66% <0.00%> (ø)
pkg/fleet/experiment.go 93.18% <93.18%> (ø)
pkg/remoteconfig/updater.go 0.00% <0.00%> (ø)
internal/controller/datadogagent/experiment.go 86.17% <86.11%> (+1.39%) ⬆️
internal/controller/datadogagent/revision.go 78.12% <79.41%> (-3.39%) ⬇️
pkg/fleet/daemon.go 65.93% <69.70%> (+65.93%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a646370...eb7b351. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khewonc khewonc force-pushed the khewonc/experiment-signals branch from e686774 to d0ff10a Compare April 7, 2026 20:03
@datadog-prod-us1-6
Copy link
Copy Markdown

❌ Code Coverage

Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

Patch coverage: 73.33% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
Patch Coverage: 73.33%
Overall Coverage: 40.58% (+0.47%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eb7b351 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants