Skip to content

update(devcontainer): update claude and golang version to 1.25.9#2885

Open
clamoriniere wants to merge 3 commits intomainfrom
clamoriniere/update-devcontainer
Open

update(devcontainer): update claude and golang version to 1.25.9#2885
clamoriniere wants to merge 3 commits intomainfrom
clamoriniere/update-devcontainer

Conversation

@clamoriniere
Copy link
Copy Markdown
Collaborator

@clamoriniere clamoriniere commented Apr 9, 2026

What does this PR do?

To be able to use the last version of claud code, we need to use for now a customer feature release until this PR is merged anthropics/devcontainer-features#37

Motivation

  • I want to use the last claude code version
  • update the devcontainer to be compatible with the golang upgrade version done in Update to Go 1.25.9 #2877

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

To be able to use the last version of claud code, we need to use for now a customer feature release until this PR is merged anthropics/devcontainer-features#37
@clamoriniere clamoriniere requested a review from a team April 9, 2026 20:29
@clamoriniere clamoriniere added this to the v1.26.0 milestone Apr 9, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65aea2da77

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -1,13 +1,14 @@
{
"image": "mcr.microsoft.com/devcontainers/go:dev-1.25",
"image": "golang:1.25.9",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep devcontainer running as non-root user

Switching the base image to golang:1.25.9 removes the default vscode user provided by the previous devcontainer image, so this container now runs as root unless a remoteUser is explicitly configured. In local Linux devcontainer setups, the postStartCommand (make install-tools) will create root-owned files in the bind-mounted repo (for example under bin/), which blocks normal host-side edits/cleanup and is a significant workflow regression. Please keep a devcontainer base that defines vscode or explicitly set up and use a non-root user.

Useful? React with 👍 / 👎.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.06%. Comparing base (5adfc81) to head (c7a9f08).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage   40.06%   40.06%           
=======================================
  Files         319      319           
  Lines       28039    28039           
=======================================
  Hits        11233    11233           
  Misses      15983    15983           
  Partials      823      823           
Flag Coverage Δ
unittests 40.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5adfc81...c7a9f08. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tbavelier tbavelier modified the milestones: v1.26.0, v1.27.0 Apr 10, 2026
@tbavelier tbavelier removed this from the v1.27.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants