Add SBOMEnabled field to CWSFeatureConfig for "package in use" feature#2904
Add SBOMEnabled field to CWSFeatureConfig for "package in use" feature#2904
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
==========================================
- Coverage 40.05% 40.02% -0.04%
==========================================
Files 319 319
Lines 28052 28469 +417
==========================================
+ Hits 11237 11394 +157
- Misses 15993 16251 +258
- Partials 822 824 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
✅ Code Coverage 🎯 Code Coverage (details) 🔗 Commit SHA: affbfcd | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Adds spec.features.cws.sbomEnabled to the DatadogAgent CRD, enabling the CWS SBOM resolver to track runtime package usage. When enabled, system-probe maps file accesses to packages and enriches SBOMs with LastSeenRunning timestamps. The env var DD_RUNTIME_SECURITY_CONFIG_SBOM_ENABLED is set on both system-probe and core agent containers.
419cee1 to
affbfcd
Compare
domalessi
left a comment
There was a problem hiding this comment.
Editorial review — one minor suggestion on the field description.
| : Enables Remote Configuration for Cloud Workload Security. Default: true | ||
|
|
||
| `features.cws.sbomEnabled` | ||
| : SBOMEnabled enables the SBOM resolver to track runtime package usage. When enabled, system-probe maps file accesses to packages and enriches SBOMs with LastSeenRunning timestamps ("package in use" feature). Default: false |
There was a problem hiding this comment.
The description opens with "SBOMEnabled enables..." which repeats the field name in the verb. Most other CWS field descriptions drop the field name (for example, "Enables Cloud Workload Security.", "Enables Remote Configuration for Cloud Workload Security.").
| : SBOMEnabled enables the SBOM resolver to track runtime package usage. When enabled, system-probe maps file accesses to packages and enriches SBOMs with LastSeenRunning timestamps ("package in use" feature). Default: false | |
| : Enables the SBOM resolver to track runtime package usage. When enabled, system-probe maps file accesses to packages and enriches SBOMs with LastSeenRunning timestamps ("package in use" feature). Default: false |
domalessi
left a comment
There was a problem hiding this comment.
Left one minor suggestion but otherwise lgtm!
What does this PR do?
Adds spec.features.cws.sbomEnabled to the DatadogAgent CRD, enabling the CWS SBOM resolver to track runtime package usage. When enabled, system-probe maps file accesses to packages and enriches SBOMs with LastSeenRunning timestamps. The env var DD_RUNTIME_SECURITY_CONFIG_SBOM_ENABLED is set on both system-probe and core agent containers.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel