Skip to content

[AWSX] feat(logs forwarder): Remove StepFunctions logic#1061

Merged
ndakkoune merged 5 commits into
masterfrom
georgi/remove-stepfunctions
Jul 22, 2026
Merged

[AWSX] feat(logs forwarder): Remove StepFunctions logic#1061
ndakkoune merged 5 commits into
masterfrom
georgi/remove-stepfunctions

Conversation

@ge0Aja

@ge0Aja ge0Aja commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Remove StepFunctions identification related logic from the forwarder.
  • Remove StepFunctions cache from the forwarder.
  • Set trace enablement for StepFunctions as a header. (will be handled in the backend)

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions Bot added the aws label Feb 3, 2026
case AwsEventSource.STEPFUNCTION:
self.handle_step_function_source(metadata, aws_attributes)

def handle_verified_access_source(self, metadata, aws_attributes):

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by cleanup

@ge0Aja ge0Aja changed the title [AWSX][WIP] feat(logs forwarder): Remove StepFunctions logic [AWSX] feat(logs forwarder): Remove StepFunctions logic Feb 4, 2026
@ge0Aja
ge0Aja marked this pull request as ready for review February 4, 2026 12:20
@ge0Aja
ge0Aja requested review from a team as code owners February 4, 2026 12:20
metadata[DD_SOURCE] = str(AwsEventSource.LAMBDA)
# Regardless of whether the log group is customized, the corresponding log stream starts with 'states/'."
if is_step_functions_log_group(log_stream):
metadata[DD_SOURCE] = str(AwsEventSource.STEPFUNCTION)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to confirm that this change will not remove source:stepfunction from the logs. This attribute is used in multiple areas of our backend, including logs pipeline, resource resolution for enrichment, and rule mapping of logs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ge0Aja Just want to confirm with you about the above statement before I approve the PR. Thanks.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 source:stepfunction will be added on the backend side once we complete the migration

@ndakkoune
ndakkoune force-pushed the georgi/remove-stepfunctions branch from a7b502a to 5e8c216 Compare July 20, 2026 08:33
@ndakkoune
ndakkoune requested a review from a team as a code owner July 20, 2026 08:33
@ndakkoune
ndakkoune merged commit 861e4be into master Jul 22, 2026
9 of 10 checks passed
@ndakkoune
ndakkoune deleted the georgi/remove-stepfunctions branch July 22, 2026 08:21
@magnetikonline

Copy link
Copy Markdown
Contributor

Just to note @ge0Aja references to DdFetchStepFunctionsTags were missed from the README.md and still exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants