feat(telemetry): append DD_TAGS to forwarder telemetry metric tags#1146
Open
patbos wants to merge 1 commit into
Open
feat(telemetry): append DD_TAGS to forwarder telemetry metric tags#1146patbos wants to merge 1 commit into
patbos wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1145
DD_TAGSis currently applied to forwarded log events but not to internal forwarder telemetry metrics (e.g.aws.dd_forwarder.logs_forwarded). This makes it impossible to filter or group those metrics by custom dimensions such as environment or AWS account ID.Changes
telemetry.py: importDD_TAGSfromsettingsand append its parsed tags toDD_FORWARDER_TELEMETRY_TAGSinset_forwarder_telemetry_tags(),, stripped of surrounding whitespace, and empty segments are ignored - consistent with howDD_TAGSis handled for log events insteps/common.pytests/test_telemetry.py: new test file covering base tags, single tag, multiple tags, whitespace stripping, empty segment filtering, and function name lowercasing