fix: reserve custom key immediately and include semver/json-array keys in SIGINT partial save#112
Merged
Merged
Conversation
…s in SIGINT partial save Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Follow up from #111 comments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses reviewer feedback from #111.
Custom key reservation: After a user confirms a custom Datadog key in the interactive conflict prompt,
reservedDatadogKeys.add(customKey)is now called immediately. Previously the key was only added to the reserved set in the create branch, so a later flag in the same run could pass the conflict check with the same key and fail at the API level with a less clear error.SIGINT partial save: The interrupt handler now includes
semverForcedClientKeysandjsonArrayWrappedKeysin the partial save, matching the success-path shape. Previously these fields were missing, so xlsx exports of interrupted saves would not show warning highlighting for SEMVER-forced and JSON-array-wrapped flags.