Skip to content

Optimise should_bypass method #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
artslidd wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Optimise should_bypass method #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions sds/src/proximity_keywords/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,30 +286,12 @@ pub enum BypassStandardizePathResult {
NoBypass,
}

pub fn should_bypass_standardize_path(characters: &str) -> BypassStandardizePathResult {
let mut all_lower = true;
let mut all_upper = true;
for char in characters.chars() {
let is_upper = char.is_ascii_uppercase();
let is_lower = char.is_ascii_lowercase();
// If it's neither an uppercase character nor a lowercase character, return NoBypass
if !is_lower && !is_upper {
return BypassStandardizePathResult::NoBypass;
}
all_lower = all_lower && is_lower;
all_upper = all_upper && is_upper;
// If we realise that we don't have all uppercase nor all lowercase, return NoBypass
if !all_lower && !all_upper {
return BypassStandardizePathResult::NoBypass;
}
}

// The characters contain only uppercase characters or only lowercase characters by now, so we can bypass
if all_lower {
BypassStandardizePathResult::BypassAndAllLowercase
pub fn should_bypass_standardize_path(s: &str) -> BypassStandardizePathResult {
return if s.chars().position(|c| !c.is_ascii_lowercase()).is_some() {
BypassStandardizePathResult::NoBypass
} else {
BypassStandardizePathResult::BypassAndAllUppercase
}
BypassStandardizePathResult::BypassAndAllLowercase
};
}

/// Function that standardizes a list of characters, by pushing characters one by one in a standard way.
Expand Down