Move match_count and suppressed_match_count to rule-level metrics#342
Draft
Move match_count and suppressed_match_count to rule-level metrics#342
Conversation
scanning.match_count and scanning.suppressed_match_count are now emitted with combined scanner+rule labels (via RuleMetrics) instead of scanner-only labels (via ScannerMetrics) CompiledRule gains two default no-op trait methods (on_match, on_suppressed_match) that RegexCompiledRule overrides to increment the per-rule counters. Three new tests verify both basic emission and correct label propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scanning.match_count and scanning.suppressed_match_count are now emitted
with combined scanner+rule labels (via RuleMetrics) instead of scanner-only
labels (via ScannerMetrics)
CompiledRule gains two default no-op trait methods (on_match,
on_suppressed_match) that RegexCompiledRule overrides to increment the
per-rule counters. Three new tests verify both basic emission and correct
label propagation.