Skip to content

fix(telemetry): report logs only once#207

Merged
dmehala merged 1 commit intomainfrom
dmehala/fix/telemetry-logs
Apr 22, 2025
Merged

fix(telemetry): report logs only once#207
dmehala merged 1 commit intomainfrom
dmehala/fix/telemetry-logs

Conversation

@dmehala
Copy link
Copy Markdown
Collaborator

@dmehala dmehala commented Apr 15, 2025

Description

Changes:

  • Update telemetry API for logs to be consistent with metrics.
  • Add test to validate logs are send in app-closing.

@dmehala dmehala requested a review from a team as a code owner April 15, 2025 12:04
@dmehala dmehala requested review from Anilm3, dubloom and pablomartinezbernardo and removed request for a team April 15, 2025 12:04
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 15, 2025

Benchmarks

Benchmark execution time: 2025-04-22 17:33:23

Comparing candidate commit e9a2fad in PR branch dmehala/fix/telemetry-logs with baseline commit 8f05ef9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (8f05ef9) to head (e9a2fad).

Files with missing lines Patch % Lines
src/datadog/telemetry/telemetry.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files          80       80           
  Lines        5083     5084    +1     
=======================================
+ Hits         4427     4428    +1     
  Misses        656      656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from dmehala/part-8-metrics-usage to main April 22, 2025 17:27
Changes:
  - Update telemetry API for logs to be consistent with metrics.
  - Add test to validate logs are send in `app-closing`.
@dmehala dmehala force-pushed the dmehala/fix/telemetry-logs branch from e82e676 to e9a2fad Compare April 22, 2025 17:30
@dmehala dmehala merged commit bc73b15 into main Apr 22, 2025
22 checks passed
@dmehala dmehala deleted the dmehala/fix/telemetry-logs branch April 22, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants