Skip to content

fix(telemetry): use tracer's service, env and runtime ID#219

Merged
dmehala merged 1 commit intomainfrom
dmehala/telemetry/set-usm
Jun 9, 2025
Merged

fix(telemetry): use tracer's service, env and runtime ID#219
dmehala merged 1 commit intomainfrom
dmehala/telemetry/set-usm

Conversation

@dmehala
Copy link
Copy Markdown
Contributor

@dmehala dmehala commented Jun 6, 2025

Description

This fixes a regression introduced during the telemetry module refactoring. When the telemetry module is initialized in the tracer context, it now correctly uses the tracer's service name, environment, and runtime ID to ensure consistency.

Changes:

  • fix reported baggage configuration values.

@dmehala dmehala requested a review from a team as a code owner June 6, 2025 15:08
@dmehala dmehala requested review from dubloom, pablomartinezbernardo and zacharycmontoya and removed request for a team and zacharycmontoya June 6, 2025 15:08
Base automatically changed from dmehala/fix/blocking-telemetry-call to main June 9, 2025 17:05
This fixes a regression introduced during the telemetry module
refactoring. When the telemetry module is initialized in the tracer
context, it now correctly uses the tracer's service name, environment,
and runtime ID to ensure consistency.
@dmehala dmehala force-pushed the dmehala/telemetry/set-usm branch from 8771e4b to 36afe44 Compare June 9, 2025 17:08
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 9, 2025

Benchmarks

Benchmark execution time: 2025-06-09 17:11:04

Comparing candidate commit 36afe44 in PR branch dmehala/telemetry/set-usm with baseline commit fe21e68 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@dmehala dmehala merged commit cf59df3 into main Jun 9, 2025
23 checks passed
@dmehala dmehala deleted the dmehala/telemetry/set-usm branch June 9, 2025 17:15
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (fe21e68) to head (36afe44).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/datadog/telemetry/telemetry.cpp 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   86.56%   86.45%   -0.11%     
==========================================
  Files          80       80              
  Lines        5248     5251       +3     
==========================================
- Hits         4543     4540       -3     
- Misses        705      711       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants