Disable legacy Gitlab exec in order to fix jobs failing with green status

[andrewlock]

Summary of changes

Disables FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY that we used before to ensure build containers have QoS guaranteed. As of now, it doesn't seem to be necessary anymore, but leads to problems like https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4119.

Reason for change

Apparently it there were issues with Gitlab CI jobs silently randomly failing with a green status.

Implementation details

Delete usages of FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY and KUBERNETES_SERVICE_ACCOUNT_OVERWRITE

Test coverage

This is the test

Other details

I based this email on similar PRs raised by @ddyurchenko e.g.

• fix(ci): disable legacy Gitlab exec in order to fix jobs failing with green status dd-trace-cpp#225
• ci: disable legacy Gitlab exec in order to fix jobs failing with green status dd-trace-js#6097

[dd-trace-dotnet-ci-bot]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (7223)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7223) - mean (68ms)  : 64, 73
     .   : milestone, 68,
    master - mean (68ms)  : 66, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (1,026ms)  : 996, 1056
     .   : milestone, 1026,
    master - mean (1,021ms)  : 1000, 1043
     .   : milestone, 1021,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (105ms)  : 104, 107
     .   : milestone, 105,
    master - mean (105ms)  : 104, 107
     .   : milestone, 105,

    section Baseline
    This PR (7223) - mean (105ms)  : 102, 108
     .   : milestone, 105,
    master - mean (105ms)  : 102, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (712ms)  : 684, 740
     .   : milestone, 712,
    master - mean (707ms)  : 693, 722
     .   : milestone, 707,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7223) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (667ms)  : 644, 690
     .   : milestone, 667,
    master - mean (667ms)  : 632, 703
     .   : milestone, 667,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (196ms)  : 189, 202
     .   : milestone, 196,
    master - mean (196ms)  : 191, 202
     .   : milestone, 196,

    section Baseline
    This PR (7223) - mean (193ms)  : 187, 199
     .   : milestone, 193,
    master - mean (193ms)  : 187, 198
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (1,141ms)  : 1114, 1167
     .   : milestone, 1141,
    master - mean (1,143ms)  : 1117, 1170
     .   : milestone, 1143,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (279ms)  : 273, 285
     .   : milestone, 279,
    master - mean (277ms)  : 271, 283
     .   : milestone, 277,

    section Baseline
    This PR (7223) - mean (278ms)  : 269, 287
     .   : milestone, 278,
    master - mean (278ms)  : 271, 286
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (907ms)  : 878, 936
     .   : milestone, 907,
    master - mean (909ms)  : 883, 934
     .   : milestone, 909,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (270ms)  : 263, 278
     .   : milestone, 270,
    master - mean (271ms)  : 265, 277
     .   : milestone, 271,

    section Baseline
    This PR (7223) - mean (269ms)  : 262, 276
     .   : milestone, 269,
    master - mean (272ms)  : 266, 278
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (900ms)  : 869, 931
     .   : milestone, 900,
    master - mean (899ms)  : 867, 931
     .   : milestone, 899,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7223) - mean (270ms)  : 261, 279
     .   : milestone, 270,
    master - mean (274ms)  : 262, 286
     .   : milestone, 274,

    section Baseline
    This PR (7223) - mean (270ms)  : 262, 278
     .   : milestone, 270,
    master - mean (272ms)  : 264, 279
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (7223) - mean (803ms)  : 778, 828
     .   : milestone, 803,
    master - mean (810ms)  : 786, 835
     .   : milestone, 810,

Loading