Skip to content

Update vendored System.Runtime.CompilerServices.Unsafe#8469

Open
andrewlock wants to merge 2 commits intoandrew/update-vendors-4from
andrew/update-vendors-7
Open

Update vendored System.Runtime.CompilerServices.Unsafe#8469
andrewlock wants to merge 2 commits intoandrew/update-vendors-4from
andrew/update-vendors-7

Conversation

@andrewlock
Copy link
Copy Markdown
Member

Summary of changes

  • Create re-usable vendoring process for System.Runtime.CompilerServices.Unsafe
  • Update the vendored code (it's actually unchanged)

Reason for change

We want to be able to update vendored code as required. For the vendored System.Runtime.CompilerServices.Unsafe package, the source code is written directly as IL, and compiled using Ilasm.exe. So this PR introduces a simple "IL to C#" converter that converts that file to its C# equivalent, using the same InlineIL.Fody approach that we currently have.

The final result produces a file that is virtually identical to the existing one (which is good!). The only difference I made was to add the original IL line as a comment next to the Fody equivalent.

This also shows that the code has not actually changed (and it's unlikely it will tbh), so this just means we have a repeatable self-contained approach to regenerate this in the repo as required.

Implementation details

Told 🤖 to make the IL to C# converter, and it did 😄 I've given the code it generated a once-over to look for anything terrible, but the key thing is that the output is sane, and that's visibly basically unchanged, so I think it's fine.

Test coverage

@dudikeleti already wrote some extensive tests for the Unsafe implementation back when he originally ported it, which verifies that we can compile the methods, call them, and that the generated IL is identical to the "real" versions 🎉

Other details

https://datadoghq.atlassian.net/browse/APMLP-1207

Part of a stack updating our vendored system code

@andrewlock andrewlock requested review from a team as code owners April 16, 2026 12:45
@andrewlock andrewlock added area:vendors Code from other vendors AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos labels Apr 16, 2026
Comment on lines -46 to -48
<!-- https://www.nuget.org/packages/System.Private.CoreLib/1.0.0 -->
<PackageReference Include="System.Private.CoreLib" Version="1.0.0" />

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the previous commit, but meh 😅

@andrewlock andrewlock force-pushed the andrew/update-vendors-4 branch from bdf65ae to ef58938 Compare April 16, 2026 13:16
@andrewlock andrewlock requested review from a team as code owners April 16, 2026 13:16
@andrewlock andrewlock force-pushed the andrew/update-vendors-7 branch from 0ec03d2 to 3af08ab Compare April 16, 2026 13:16
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 16, 2026

Benchmarks

Benchmark execution time: 2026-04-16 14:23:18

Comparing candidate commit 3af08ab in PR branch andrew/update-vendors-7 with baseline commit 5f3c2a8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.005%]
  • ignore execution_time [-1.856ms; -0.866ms] or [-0.922%; -0.430%]
  • ignore throughput [+871.055op/s; +1421.624op/s] or [+1.033%; +1.686%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [-1800.192µs; +1704.235µs] or [-0.898%; +0.850%]
  • 🟩 throughput [+7993.968op/s; +10307.326op/s] or [+6.719%; +8.664%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • ignore execution_time [-7.570ms; -0.477ms] or [-3.807%; -0.240%]
  • ignore throughput [+1544.319op/s; +2734.006op/s] or [+1.570%; +2.780%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [-4 bytes; -3 bytes] or [-0.127%; -0.114%]
  • 🟥 execution_time [+307.514ms; +310.934ms] or [+152.599%; +154.297%]
  • ignore throughput [-4.170op/s; +1.537op/s] or [-0.750%; +0.276%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+386.403ms; +388.145ms] or [+305.282%; +306.658%]
  • ignore throughput [+15.694op/s; +18.030op/s] or [+2.069%; +2.377%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+394.832ms; +396.843ms] or [+349.411%; +351.191%]
  • ignore throughput [-6.299op/s; -0.984op/s] or [-0.890%; -0.139%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]
  • ignore execution_time [-100.162µs; +625.032µs] or [-0.050%; +0.312%]
  • ignore throughput [-4056.602op/s; -3596.325op/s] or [-3.156%; -2.798%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-15.751ms; -11.578ms] or [-7.356%; -5.407%]
  • ignore throughput [+5300.239op/s; +8093.973op/s] or [+3.869%; +5.908%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]
  • ignore execution_time [-13.127ms; -8.945ms] or [-6.251%; -4.259%]
  • ignore throughput [-1599.878op/s; +734.177op/s] or [-1.446%; +0.664%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • ignore execution_time [-1100.772µs; -531.672µs] or [-0.548%; -0.265%]
  • 🟥 throughput [-233843.073op/s; -230663.158op/s] or [-23.877%; -23.552%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-26.241ms; -21.385ms] or [-11.702%; -9.537%]
  • ignore throughput [-64744.890op/s; -41749.877op/s] or [-6.917%; -4.460%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • ignore execution_time [-3.337ms; +0.980ms] or [-1.665%; +0.489%]
  • 🟥 throughput [-131485.908op/s; -115500.302op/s] or [-18.892%; -16.595%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [-1021.798µs; +6.822µs] or [-0.509%; +0.003%]
  • ignore throughput [-401.416op/s; +364.949op/s] or [-0.270%; +0.246%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • ignore execution_time [+1.153ms; +4.633ms] or [+0.582%; +2.338%]
  • 🟩 throughput [+9468.810op/s; +12396.591op/s] or [+6.025%; +7.888%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+1.641ms; +5.631ms] or [+0.837%; +2.871%]
  • 🟩 throughput [+7781.063op/s; +10411.875op/s] or [+6.199%; +8.294%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • ignore execution_time [-321.376µs; -116.541µs] or [-0.160%; -0.058%]
  • ignore throughput [+41550.946op/s; +50144.441op/s] or [+1.264%; +1.525%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.008%]
  • ignore execution_time [-2004.671µs; +790.457µs] or [-0.991%; +0.391%]
  • 🟩 throughput [+406126.398op/s; +449876.699op/s] or [+13.542%; +15.001%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • 🟩 execution_time [-19.541ms; -15.185ms] or [-9.008%; -7.000%]
  • 🟩 throughput [+200694.230op/s; +255511.411op/s] or [+7.966%; +10.142%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • ignore allocated_mem [+0 bytes; +2 bytes] or [-0.001%; +0.007%]
  • 🟥 execution_time [+300.173ms; +300.830ms] or [+149.986%; +150.315%]
  • ignore throughput [+94.165op/s; +136.384op/s] or [+1.040%; +1.506%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+298.617ms; +301.922ms] or [+150.593%; +152.260%]
  • ignore throughput [+311.685op/s; +522.124op/s] or [+2.384%; +3.993%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+300.713ms; +303.379ms] or [+151.476%; +152.819%]
  • ignore throughput [+88.242op/s; +216.183op/s] or [+0.852%; +2.087%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • ignore allocated_mem [+3 bytes; +4 bytes] or [+0.186%; +0.199%]
  • 🟥 execution_time [+296.065ms; +296.776ms] or [+145.415%; +145.765%]
  • ignore throughput [-7.351op/s; +2.066op/s] or [-0.195%; +0.055%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+294.893ms; +298.172ms] or [+144.162%; +145.765%]
  • ignore throughput [+138.505op/s; +186.641op/s] or [+2.012%; +2.712%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+300.766ms; +302.062ms] or [+150.322%; +150.970%]
  • ignore throughput [+52.034op/s; +75.507op/s] or [+1.033%; +1.499%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+2.521µs; +6.149µs] or [+0.518%; +1.263%]
  • ignore throughput [-25.392op/s; -10.406op/s] or [-1.237%; -0.507%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.010%]
  • ignore execution_time [+12.139µs; +38.840µs] or [+2.784%; +8.908%]
  • ignore throughput [-192.800op/s; -72.629op/s] or [-8.382%; -3.158%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [+5.878µs; +27.802µs] or [+1.259%; +5.957%]
  • ignore throughput [-138.538op/s; -57.951op/s] or [-6.395%; -2.675%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-3.496µs; +0.684µs] or [-0.944%; +0.185%]
  • ignore throughput [-4.135op/s; +25.960op/s] or [-0.153%; +0.961%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • 🟥 execution_time [+23.316µs; +46.922µs] or [+7.444%; +14.980%]
  • 🟥 throughput [-435.931op/s; -237.287op/s] or [-13.589%; -7.397%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [-16.732µs; +5.616µs] or [-4.577%; +1.536%]
  • ignore throughput [-75.148op/s; +58.146op/s] or [-2.697%; +2.087%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.794ms; +300.456ms] or [+149.628%; +149.958%]
  • ignore throughput [+3568962.041op/s; +4138115.095op/s] or [+1.788%; +2.073%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • ignore allocated_mem [+120 bytes; +122 bytes] or [+0.670%; +0.681%]
  • unstable execution_time [+371.388ms; +408.272ms] or [+403.528%; +443.604%]
  • 🟩 throughput [+1102.449op/s; +1254.762op/s] or [+9.059%; +10.311%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • ignore allocated_mem [+70 bytes; +72 bytes] or [+0.338%; +0.350%]
  • unstable execution_time [+251.947ms; +297.949ms] or [+191.301%; +226.230%]
  • 🟩 throughput [+652.321op/s; +857.088op/s] or [+6.315%; +8.297%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [+2.796KB; +2.801KB] or [+4.968%; +4.977%]
  • unstable execution_time [+248.305ms; +323.451ms] or [+114.168%; +148.719%]
  • 🟥 throughput [-639.872op/s; -565.616op/s] or [-57.979%; -51.250%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [-1.270KB; -1.268KB] or [-2.995%; -2.990%]
  • unstable execution_time [+202.358ms; +335.585ms] or [+86.237%; +143.012%]
  • 🟥 throughput [-746.940op/s; -663.217op/s] or [-49.821%; -44.237%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+953 bytes; +957 bytes] or [+2.253%; +2.260%]
  • 🟥 execution_time [+335.147ms; +345.381ms] or [+200.457%; +206.578%]
  • 🟥 throughput [-409.057op/s; -373.114op/s] or [-28.482%; -25.979%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-69.964µs; -50.533µs] or [-3.521%; -2.543%]
  • ignore throughput [+13.478op/s; +18.636op/s] or [+2.678%; +3.703%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-21.427µs; -5.037µs] or [-1.472%; -0.346%]
  • ignore throughput [+2.929op/s; +10.700op/s] or [+0.426%; +1.558%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-118.487µs; -103.705µs] or [-4.122%; -3.608%]
  • ignore throughput [+13.100op/s; +14.997op/s] or [+3.766%; +4.311%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-10.255µs; +0.876µs] or [-0.886%; +0.076%]
  • ignore throughput [-0.027op/s; +7.957op/s] or [-0.003%; +0.921%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-50.588µs; -33.839µs] or [-4.692%; -3.138%]
  • ignore throughput [+30.883op/s; +47.987op/s] or [+3.330%; +5.174%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-89.502µs; +13.831µs] or [-4.795%; +0.741%]
  • unstable throughput [+1.832op/s; +68.403op/s] or [+0.342%; +12.768%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

  • ignore allocated_mem [-43 bytes; +21 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+19.744µs; +29.447µs] or [+0.771%; +1.150%]
  • ignore throughput [-4.409op/s; -2.964op/s] or [-1.129%; -0.759%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • ignore allocated_mem [-38 bytes; +46 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [+27.540µs; +68.165µs] or [+1.395%; +3.453%]
  • ignore throughput [-15.916op/s; -5.354op/s] or [-3.142%; -1.057%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • ignore allocated_mem [-42 bytes; +23 bytes] or [-0.007%; +0.004%]
  • ignore execution_time [-351.934µs; -157.594µs] or [-8.925%; -3.996%]
  • 🟩 throughput [+13.439op/s; +38.359op/s] or [+5.300%; +15.126%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • 🟥 execution_time [+301.786ms; +303.939ms] or [+151.974%; +153.058%]
  • ignore throughput [+7338.645op/s; +9216.687op/s] or [+2.361%; +2.966%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+298.831ms; +300.672ms] or [+149.745%; +150.667%]
  • ignore throughput [+11896.590op/s; +17919.316op/s] or [+1.876%; +2.825%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+302.039ms; +305.111ms] or [+151.732%; +153.275%]
  • ignore throughput [+20236.254op/s; +27660.430op/s] or [+4.263%; +5.827%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • 🟥 execution_time [+301.363ms; +302.636ms] or [+151.334%; +151.974%]
  • ignore throughput [+4858.869op/s; +6440.614op/s] or [+1.628%; +2.158%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.006%]
  • 🟥 execution_time [+298.780ms; +300.590ms] or [+147.734%; +148.628%]
  • ignore throughput [+141.656op/s; +6256.536op/s] or [+0.023%; +1.008%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+304.418ms; +308.519ms] or [+154.293%; +156.371%]
  • ignore throughput [-13047.299op/s; -4814.634op/s] or [-2.817%; -1.040%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • ignore allocated_mem [+0 bytes; +1 bytes] or [+0.108%; +0.119%]
  • 🟥 execution_time [+300.370ms; +302.131ms] or [+150.759%; +151.643%]
  • ignore throughput [+690.573op/s; +3080.617op/s] or [+0.179%; +0.799%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+300.057ms; +306.258ms] or [+149.551%; +152.642%]
  • 🟩 throughput [+46566.190op/s; +53664.419op/s] or [+9.247%; +10.656%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+301.673ms; +304.326ms] or [+150.080%; +151.400%]
  • ignore throughput [-6106.393op/s; -587.475op/s] or [-1.445%; -0.139%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [-1042.848µs; -153.372µs] or [-0.518%; -0.076%]
  • ignore throughput [+682.106op/s; +1791.942op/s] or [+0.274%; +0.721%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.003%]
  • 🟩 execution_time [-16.506ms; -12.861ms] or [-7.675%; -5.980%]
  • ignore throughput [+18052.519op/s; +25033.977op/s] or [+4.952%; +6.868%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.008%]
  • ignore execution_time [-0.544ms; +3.404ms] or [-0.273%; +1.708%]
  • ignore throughput [+1619.004op/s; +7381.629op/s] or [+0.591%; +2.694%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • ignore allocated_mem [-4.459KB; -4.431KB] or [-1.623%; -1.613%]
  • unstable execution_time [+11.590µs; +54.181µs] or [+2.863%; +13.383%]
  • ignore throughput [-273.111op/s; -65.058op/s] or [-10.990%; -2.618%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-17.994KB; -17.972KB] or [-6.564%; -6.556%]
  • unstable execution_time [-47.501µs; +5.220µs] or [-9.388%; +1.032%]
  • ignore throughput [-6.439op/s; +178.065op/s] or [-0.321%; +8.886%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • ignore allocated_mem [+2.394KB; +2.411KB] or [+0.873%; +0.879%]
  • ignore execution_time [-56.175µs; -0.028µs] or [-9.735%; -0.005%]
  • ignore throughput [+12.672op/s; +165.345op/s] or [+0.724%; +9.446%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472

  • ignore allocated_mem [-2 bytes; +2 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [+1.218µs; +2.662µs] or [+2.111%; +4.612%]
  • ignore throughput [-754.832op/s; -348.885op/s] or [-4.356%; -2.013%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • ignore allocated_mem [-4 bytes; +0 bytes] or [-0.010%; -0.001%]
  • 🟥 execution_time [+7.509µs; +11.598µs] or [+17.749%; +27.413%]
  • 🟥 throughput [-5159.563op/s; -3387.671op/s] or [-21.720%; -14.261%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +1 bytes] or [-0.002%; +0.002%]
  • unstable execution_time [-13.885µs; -6.727µs] or [-21.543%; -10.436%]
  • 🟩 throughput [+1710.182op/s; +3229.928op/s] or [+10.493%; +19.817%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • ignore allocated_mem [+1 bytes; +2 bytes] or [+0.039%; +0.050%]
  • 🟥 execution_time [+302.223ms; +303.615ms] or [+152.760%; +153.464%]
  • ignore throughput [-190.913op/s; -166.801op/s] or [-3.190%; -2.787%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [-1 bytes; +0 bytes] or [-0.027%; -0.017%]
  • 🟥 execution_time [+301.786ms; +303.939ms] or [+153.608%; +154.704%]
  • ignore throughput [-131.013op/s; -55.961op/s] or [-1.625%; -0.694%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +0 bytes] or [-0.027%; -0.017%]
  • 🟥 execution_time [+299.850ms; +301.977ms] or [+150.112%; +151.177%]
  • ignore throughput [-176.992op/s; -114.047op/s] or [-2.255%; -1.453%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [-931.214µs; -213.866µs] or [-0.464%; -0.107%]
  • ignore throughput [-11752.774op/s; -10364.360op/s] or [-3.253%; -2.869%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.007%]
  • ignore execution_time [-265.965µs; +404.487µs] or [-0.133%; +0.202%]
  • 🟩 throughput [+44051.242op/s; +48159.092op/s] or [+8.338%; +9.116%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.006%]
  • ignore execution_time [+1.415ms; +5.082ms] or [+0.717%; +2.576%]
  • ignore throughput [-13718.165op/s; -5323.735op/s] or [-3.247%; -1.260%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • 🟥 execution_time [+299.742ms; +301.487ms] or [+149.394%; +150.264%]
  • ignore throughput [-1577.909op/s; -564.389op/s] or [-1.042%; -0.373%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+0.000%; +0.009%]
  • 🟥 execution_time [+301.311ms; +302.338ms] or [+151.304%; +151.820%]
  • ignore throughput [+3237.014op/s; +5176.506op/s] or [+1.408%; +2.251%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • 🟥 execution_time [+303.261ms; +305.491ms] or [+153.795%; +154.925%]
  • ignore throughput [-4988.295op/s; -2840.861op/s] or [-2.809%; -1.600%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+300.276ms; +300.958ms] or [+149.779%; +150.120%]
  • 🟩 throughput [+66056893.890op/s; +66339734.891op/s] or [+48.107%; +48.313%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • ignore allocated_mem [+64 bytes; +65 bytes] or [+0.373%; +0.383%]
  • unstable execution_time [+344.043ms; +388.168ms] or [+427.879%; +482.756%]
  • 🟩 throughput [+991.181op/s; +1162.911op/s] or [+7.662%; +8.990%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.526ms; +300.458ms] or [+149.397%; +149.862%]
  • 🟩 throughput [+18217383.212op/s; +19162642.701op/s] or [+8.069%; +8.488%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-418.925µs; -101.606µs] or [-0.210%; -0.051%]
  • ignore throughput [+10031.058op/s; +14961.078op/s] or [+1.119%; +1.670%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-4.900ms; -3.438ms] or [-2.400%; -1.684%]
  • 🟩 throughput [+82221.841op/s; +91542.002op/s] or [+7.677%; +8.547%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [+0.944ms; +5.013ms] or [+0.478%; +2.537%]
  • 🟩 throughput [+52740.095op/s; +71898.713op/s] or [+6.105%; +8.322%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.009%]
  • ignore execution_time [-84.087µs; +147.100µs] or [-0.042%; +0.074%]
  • ignore throughput [-9464.149op/s; -2449.833op/s] or [-0.866%; -0.224%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • ignore execution_time [+5.621ms; +9.740ms] or [+2.929%; +5.074%]
  • 🟩 throughput [+65345.774op/s; +95391.184op/s] or [+5.058%; +7.383%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • ignore execution_time [-4.531ms; -3.000ms] or [-2.226%; -1.474%]
  • 🟩 throughput [+94578.058op/s; +102877.813op/s] or [+9.393%; +10.217%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.002%]
  • ignore execution_time [-1.730ms; -0.523ms] or [-0.861%; -0.260%]
  • ignore throughput [+14874.292op/s; +18113.490op/s] or [+3.314%; +4.036%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • ignore execution_time [-1288.543µs; +265.154µs] or [-0.643%; +0.132%]
  • 🟩 throughput [+45799.456op/s; +51266.930op/s] or [+8.316%; +9.309%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • ignore execution_time [+0.461ms; +4.551ms] or [+0.231%; +2.286%]
  • 🟩 throughput [+27184.730op/s; +36812.645op/s] or [+6.085%; +8.240%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-563.315µs; +445.814µs] or [-0.281%; +0.222%]
  • ignore throughput [-30365.109op/s; -26360.536op/s] or [-4.444%; -3.858%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-1237.661µs; +2263.731µs] or [-0.619%; +1.132%]
  • 🟩 throughput [+78329.898op/s; +96722.831op/s] or [+8.751%; +10.806%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [+1.527ms; +5.433ms] or [+0.775%; +2.759%]
  • ignore throughput [+28259.768op/s; +42911.176op/s] or [+3.946%; +5.991%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos area:vendors Code from other vendors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant