refactor(franz-go): use hooks instead of wrapping#4623
Draft
rarguelloF wants to merge 7 commits intoaugusto/add-twmb-franz-go-integrationfrom
Draft
refactor(franz-go): use hooks instead of wrapping#4623rarguelloF wants to merge 7 commits intoaugusto/add-twmb-franz-go-integrationfrom
rarguelloF wants to merge 7 commits intoaugusto/add-twmb-franz-go-integrationfrom
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 80e87f8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
5b5dc46 to
e232b43
Compare
e232b43 to
fa32031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the hooks added in twmb/franz-go#1289 to implement the integration without needing to return a custom type (see https://github.com/DataDog/dd-trace-go/pull/4250/changes#r2952440108 for more context).
Additional changes:
WithAnalyticsoptions.Motivation
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.Unsure? Have a question? Request a review!