Skip to content

refactor(franz-go): use hooks instead of wrapping#4623

Draft
rarguelloF wants to merge 7 commits intoaugusto/add-twmb-franz-go-integrationfrom
rarguelloF/franz-go-hooks
Draft

refactor(franz-go): use hooks instead of wrapping#4623
rarguelloF wants to merge 7 commits intoaugusto/add-twmb-franz-go-integrationfrom
rarguelloF/franz-go-hooks

Conversation

@rarguelloF
Copy link
Copy Markdown
Contributor

@rarguelloF rarguelloF commented Mar 31, 2026

What does this PR do?

Use the hooks added in twmb/franz-go#1289 to implement the integration without needing to return a custom type (see https://github.com/DataDog/dd-trace-go/pull/4250/changes#r2952440108 for more context).

Additional changes:

  • Use instrumentation/testutils/containers for the integration tests.
  • Remove unnecessary locking when reading the consumer group ID.
  • Remove deprecated WithAnalytics options.
  • Remove unnecessary build tags.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 31, 2026
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 bot commented Mar 31, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.06% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 80e87f8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@genesor genesor changed the base branch from augusto/add-twmb-franz-go-integration to main March 31, 2026 11:55
@genesor genesor changed the base branch from main to augusto/add-twmb-franz-go-integration April 1, 2026 11:06
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.72%. Comparing base (58773e1) to head (80e87f8).

Additional details and impacted files
Files with missing lines Coverage Δ
internal/stacktrace/contribs_generated.go 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@genesor genesor force-pushed the rarguelloF/franz-go-hooks branch from 5b5dc46 to e232b43 Compare April 1, 2026 16:49
@genesor genesor force-pushed the rarguelloF/franz-go-hooks branch from e232b43 to fa32031 Compare April 1, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants