Skip to content

feat(franz-go): add orchestrion aspect for automatic instrumentation#4629

Draft
genesor wants to merge 5 commits intorarguelloF/franz-go-hooksfrom
ben.db/franz-go-orchestrion
Draft

feat(franz-go): add orchestrion aspect for automatic instrumentation#4629
genesor wants to merge 5 commits intorarguelloF/franz-go-hooksfrom
ben.db/franz-go-orchestrion

Conversation

@genesor
Copy link
Copy Markdown
Member

@genesor genesor commented Apr 2, 2026

What does this PR do?

Adds orchestrion support for the twmb/franz-go integration:

  • Adds orchestrion.yml aspect that hooks into kgo.NewClient() and appends WithTracing() to enable automatic distributed tracing
  • Registers the aspect in orchestrion/all
  • Adds an orchestrion integration test at internal/orchestrion/_integration/twmb_franz_go/
  • Adds the franz-go replace directive to the integration test module

Motivation

Enable automatic instrumentation of franz-go Kafka clients via orchestrion, matching the existing pattern used by other integrations (gRPC, segmentio/kafka-go, etc.).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.70%. Comparing base (80e87f8) to head (bc7a982).

Additional details and impacted files

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 bot commented Apr 2, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.11% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bc7a982 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@genesor genesor force-pushed the ben.db/franz-go-orchestrion branch from d92d2ab to bc7a982 Compare April 2, 2026 12:01
client.Close()
}

func (tc *TestCase) createTopic(t *testing.T) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does createTopic actually get called?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it's not used anymore. I will double check the integration test before opening the PR. For now we're stuck with the upstream lib PR anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants