feat(franz-go): add orchestrion aspect for automatic instrumentation#4629
Draft
genesor wants to merge 5 commits intorarguelloF/franz-go-hooksfrom
Draft
feat(franz-go): add orchestrion aspect for automatic instrumentation#4629genesor wants to merge 5 commits intorarguelloF/franz-go-hooksfrom
genesor wants to merge 5 commits intorarguelloF/franz-go-hooksfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: bc7a982 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
d92d2ab to
bc7a982
Compare
kakkoyun
reviewed
Apr 8, 2026
| client.Close() | ||
| } | ||
|
|
||
| func (tc *TestCase) createTopic(t *testing.T) { |
Member
There was a problem hiding this comment.
Where does createTopic actually get called?
Member
Author
There was a problem hiding this comment.
I'm pretty sure it's not used anymore. I will double check the integration test before opening the PR. For now we're stuck with the upstream lib PR anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds orchestrion support for the twmb/franz-go integration:
orchestrion.ymlaspect that hooks intokgo.NewClient()and appendsWithTracing()to enable automatic distributed tracingorchestrion/allinternal/orchestrion/_integration/twmb_franz_go/Motivation
Enable automatic instrumentation of franz-go Kafka clients via orchestrion, matching the existing pattern used by other integrations (gRPC, segmentio/kafka-go, etc.).
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.