fix(contrib/aws/aws-sdk-go-v2): skip _datadog attribute if batch size larger than 262144-byte payload limit#4665
fix(contrib/aws/aws-sdk-go-v2): skip _datadog attribute if batch size larger than 262144-byte payload limit#4665
_datadog attribute if batch size larger than 262144-byte payload limit#4665Conversation
…ze higher than 262144-byte payload limit
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 3ba0d06 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9506d95b00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-04-17 12:04:29 Comparing candidate commit 3ba0d06 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 270 metrics, 8 unstable metrics.
|
…TraceContext` doesn't inject
What does this PR do?
SNS
_datadogtrace context injection (about 338 bytes) was unconditionally added to every message, pushing payloads over SNS's 262,144-byte limit and causingBatchRequestTooLongerrors.Motivation
Fixes #4664.
Reviewer's Checklist
make lintlocally.make testlocally.Unsure? Have a question? Request a review!