Skip to content

fix(scripts): ensure that generate and fix-modules to include transitive dd-trace-go packages#4675

Open
darccio wants to merge 2 commits intomainfrom
dario.castane/ktlo/transitive-deps-generate
Open

fix(scripts): ensure that generate and fix-modules to include transitive dd-trace-go packages#4675
darccio wants to merge 2 commits intomainfrom
dario.castane/ktlo/transitive-deps-generate

Conversation

@darccio
Copy link
Copy Markdown
Member

@darccio darccio commented Apr 17, 2026

What does this PR do?

Enhances internal/orchestrion/generator and scripts/fixmodules to add all the dd-trace-go direct and transitive dependencies in all the go.mod files.

Motivation

Avoid accidental breakage when bumping versions everywhere in dd-trace-go.

Reviewer's Checklist

  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • New code is free of linting errors. You can check this by running make lint locally.
  • New code doesn't break existing tests. You can check this by running make test locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • All generated files are up to date. You can check this by running make generate locally.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild. Make sure all nested modules are up to date by running make fix-modules locally.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners April 17, 2026 20:50
@darccio darccio added team:apm-go AI Assisted AI/LLM assistance used in this PR (partially or fully) labels Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.47%. Comparing base (9f3aa1f) to head (f3d7aed).

Files with missing lines Patch % Lines
internal/orchestrion/generator/main.go 0.00% 47 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
internal/orchestrion/generator/main.go 0.00% <0.00%> (ø)

... and 447 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 bot commented Apr 17, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 60.77% (+3.84%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f3d7aed | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 17, 2026

Benchmarks

Benchmark execution time: 2026-04-17 21:19:04

Comparing candidate commit f3d7aed in PR branch dario.castane/ktlo/transitive-deps-generate with baseline commit 9f3aa1f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 270 metrics, 8 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@darccio
Copy link
Copy Markdown
Member Author

darccio commented Apr 18, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Assisted AI/LLM assistance used in this PR (partially or fully) team:apm-go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant