fix(contrib/aws/datadog-lambda): collapse multi-line JSON before sorting log comparison#4683
fix(contrib/aws/datadog-lambda): collapse multi-line JSON before sorting log comparison#4683joeyzhao2018 wants to merge 2 commits intomainfrom
Conversation
…ing log comparison The previous line-level sort fragmented multi-line JSON blocks, causing diff to misalign identical log entries that appeared at different positions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52285cdd5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 94ba7a0 | Docs | Datadog PR Page | Give us feedback! |
Use Perl's recursive pattern (?1) to match balanced braces at any nesting depth, not just one level. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BenchmarksBenchmark execution time: 2026-04-20 20:17:28 Comparing candidate commit 94ba7a0 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 205 metrics, 7 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
What does this PR do?
positions across runs (non-deterministic Lambda/CloudWatch log ordering)
blocks — lines like {, }, "v": 1 got scattered by sort, causing diff to misalign even when the logical content was identical
single sortable unit